Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1883293005: Allow opening a named pipe on MacOS and Linux. (Closed)

Created:
4 years, 8 months ago by zra
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Søren Gjesse
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow opening a named pipe on MacOS and Linux. fixes #26237 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8caa5a6dcb9f35a101516460d6b0abf12affeaf5

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M runtime/bin/file_linux.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A tests/standalone/io/named_pipe_script_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 8 months ago (2016-04-15 16:39:00 UTC) #2
rmacnak
lgtm https://chromiumcodereview.appspot.com/1883293005/diff/1/runtime/bin/file_linux.cc File runtime/bin/file_linux.cc (right): https://chromiumcodereview.appspot.com/1883293005/diff/1/runtime/bin/file_linux.cc#newcode158 runtime/bin/file_linux.cc:158: // Only accept regular files and character devices. ...
4 years, 8 months ago (2016-04-15 17:17:30 UTC) #3
zra
Thanks! https://chromiumcodereview.appspot.com/1883293005/diff/1/runtime/bin/file_linux.cc File runtime/bin/file_linux.cc (right): https://chromiumcodereview.appspot.com/1883293005/diff/1/runtime/bin/file_linux.cc#newcode158 runtime/bin/file_linux.cc:158: // Only accept regular files and character devices. ...
4 years, 8 months ago (2016-04-15 18:19:15 UTC) #4
zra
4 years, 8 months ago (2016-04-15 18:19:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8caa5a6dcb9f35a101516460d6b0abf12affeaf5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698