Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: runtime/bin/file_macos.cc

Issue 1883293005: Allow opening a named pipe on MacOS and Linux. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/file_linux.cc ('k') | tests/standalone/io/named_pipe_script_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/file_macos.cc
diff --git a/runtime/bin/file_macos.cc b/runtime/bin/file_macos.cc
index 81412f66e0c4440a4898e8bf8076cfae33fe7fcd..1b5ee0412284013032a881846c5478701cf65906 100644
--- a/runtime/bin/file_macos.cc
+++ b/runtime/bin/file_macos.cc
@@ -158,8 +158,8 @@ File* File::ScopedOpen(const char* name, FileOpenMode mode) {
// Report errors for non-regular files.
struct stat st;
if (NO_RETRY_EXPECTED(stat(name, &st)) == 0) {
- // Only accept regular files and character devices.
- if (!S_ISREG(st.st_mode) && !S_ISCHR(st.st_mode)) {
+ // Only accept regular files, character devices, and pipes.
+ if (!S_ISREG(st.st_mode) && !S_ISCHR(st.st_mode) && !S_ISFIFO(st.st_mode)) {
errno = (S_ISDIR(st.st_mode)) ? EISDIR : ENOENT;
return NULL;
}
« no previous file with comments | « runtime/bin/file_linux.cc ('k') | tests/standalone/io/named_pipe_script_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698