Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1883263002: mash: Repost mouse pressed event when closing Ash system tray (Closed)

Created:
4 years, 8 months ago by James Cook
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Repost mouse pressed event when closing Ash system tray * Change OnWindowInputEventAck to take an enum for the event result (handled, unhandled, or repost) instead of a bool. Plumb this through the event dispatch system. * Always cache the input event awaiting acknowledgement in WindowManagerState, not just for accelerator events. * Repost input events at their original location, rather than their transformed location, so they can target other windows correctly. * Introduce a MessageLoop::NestingObserver so that mus client apps can immediately acknowledge input events that trigger a nested message. For automated tests: * Track the location of events when recording WindowTreeClient changes. * Add a SurfacesState to WindowManagerStateTest so that hit testing works properly. BUG=599142 TEST=Unit tests added to base_unittests and mus_ws_unittests. Manual test is to open system tray menu, then click on Quick Launch close box. Both will close.

Patch Set 1 #

Patch Set 2 : rebase and format #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -134 lines) Patch
M base/message_loop/message_loop.h View 4 chunks +19 lines, -0 lines 0 comments Download
M base/message_loop/message_loop.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M base/message_loop/message_loop_test.h View 2 chunks +4 lines, -0 lines 0 comments Download
M base/message_loop/message_loop_test.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M base/run_loop.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/mus/public/cpp/input_event_handler.h View 1 chunk +6 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/public/cpp/tests/test_window_tree.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/public/cpp/tests/test_window_tree.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 1 3 chunks +11 lines, -2 lines 0 comments Download
M components/mus/ws/event_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/mus/ws/event_dispatcher_delegate.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/mus/ws/test_change_tracker.h View 1 3 chunks +6 lines, -1 line 0 comments Download
M components/mus/ws/test_change_tracker.cc View 1 2 chunks +10 lines, -1 line 0 comments Download
M components/mus/ws/test_utils.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/mus/ws/test_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_manager_state.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/mus/ws/window_manager_state.cc View 1 7 chunks +29 lines, -14 lines 0 comments Download
M components/mus/ws/window_manager_state_unittest.cc View 1 2 19 chunks +79 lines, -24 lines 0 comments Download
M components/mus/ws/window_tree.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/window_tree.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M components/mus/ws/window_tree_client_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.h View 2 chunks +6 lines, -4 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 1 2 4 chunks +12 lines, -8 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection_unittest.cc View 1 16 chunks +33 lines, -31 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M ui/views/mus/platform_window_mus.h View 1 3 chunks +13 lines, -2 lines 0 comments Download
M ui/views/mus/platform_window_mus.cc View 1 5 chunks +47 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
James Cook
sky, please take a look.
4 years, 8 months ago (2016-04-14 21:44:56 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883263002/40001
4 years, 8 months ago (2016-04-14 21:45:54 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/145120) linux_chromium_clobber_rel_ng on ...
4 years, 8 months ago (2016-04-14 21:51:32 UTC) #7
James Cook
4 years, 7 months ago (2016-04-27 15:15:06 UTC) #9
Abandoned. I've extracted the useful bits of this into other CLs (notably the
messageloop / event acking bits into https://codereview.chromium.org/1891233006/
).

Powered by Google App Engine
This is Rietveld 408576698