Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1883233002: Fix tooltips for Chrome OS shelf overflow icons. (Closed)

Created:
4 years, 8 months ago by msw
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix tooltips for Chrome OS shelf overflow icons. Fixes a regression from https://codereview.chromium.org/1816753002 Add OverflowBubbleView's ShelfView after creating the bubble widget. (ShelfTooltipManager init requires the widget to exist first) BUG=601880 TEST=Chrome OS shelf overflow bubble shows tooltips. R=sky@chromium.org Review URL: https://codereview.chromium.org/1875033004 Cr-Commit-Position: refs/heads/master@{#386471} (cherry picked from commit 01b843768f112912493d5a2510ecd6e09b0ed7bf) Committed: https://chromium.googlesource.com/chromium/src/+/d1efceaa570b35862ecec60eaca67090fa3a1ade

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/shelf/overflow_bubble_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
msw
4 years, 8 months ago (2016-04-14 18:54:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1efceaa570b35862ecec60eaca67090fa3a1ade.

Powered by Google App Engine
This is Rietveld 408576698