Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1875033004: Fix tooltips for Chrome OS shelf overflow icons. (Closed)

Created:
4 years, 8 months ago by msw
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tooltips for Chrome OS shelf overflow icons. Fixes a regression from https://codereview.chromium.org/1816753002 Add OverflowBubbleView's ShelfView after creating the bubble widget. (ShelfTooltipManager init requires the widget to exist first) BUG=601880 TEST=Chrome OS shelf overflow bubble shows tooltips. R=sky@chromium.org Committed: https://crrev.com/01b843768f112912493d5a2510ecd6e09b0ed7bf Cr-Commit-Position: refs/heads/master@{#386471}

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/shelf/overflow_bubble_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 8 months ago (2016-04-11 19:04:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875033004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875033004/20001
4 years, 8 months ago (2016-04-11 19:05:07 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 19:49:01 UTC) #5
sky
LGTM
4 years, 8 months ago (2016-04-11 20:56:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875033004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875033004/20001
4 years, 8 months ago (2016-04-11 21:02:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 21:09:56 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 21:11:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01b843768f112912493d5a2510ecd6e09b0ed7bf
Cr-Commit-Position: refs/heads/master@{#386471}

Powered by Google App Engine
This is Rietveld 408576698