Fixed regression in WEBGL_draw_buffers support

Fixed regression in WEBGL_draw_buffers support

The WebGLDrawBuffers::satisfiesWebGLRequirements check was relying on
Blink-side emulation of support for separate DEPTH and STENCIL targets,
which was removed and the logic pushed to the command buffer in an
earlier patch.

BUG=586536
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/fa81f67b9e865a3be27edd9b5d4593f04f3e1b2b
Cr-Commit-Position: refs/heads/master@{#387747}

[bajones, 2016-04-14 17:59:50]

Description was changed from

==========
Fixed regression in WEBGL_draw_buffers support

The WebGLDrawBuffers::satisfiesWebGLRequirements check was relying on
Blink-side emulation of support for separate DEPTH and STENCIL targets,
which was removed and the logic pushed to the command buffer in an
earlier patch.

BUG=586536
==========

to

==========
Fixed regression in WEBGL_draw_buffers support

The WebGLDrawBuffers::satisfiesWebGLRequirements check was relying on
Blink-side emulation of support for separate DEPTH and STENCIL targets,
which was removed and the logic pushed to the command buffer in an
earlier patch.

BUG=586536
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[bajones, 2016-04-14 19:08:45]

bajones@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[Zhenyao Mo, 2016-04-14 20:15:15]

lgtm

https://codereview.chromium.org/1883153003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp (right):

https://codereview.chromium.org/1883153003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp:30: #include
"wtf/Assertions.h"
why do you need this?

[Ken Russell (switch to Gerrit), 2016-04-14 20:33:08]

lgtm

https://codereview.chromium.org/1883153003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp (right):

https://codereview.chromium.org/1883153003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp:144: 
If you can undo this whitespace change and the one below it might make it easier
to merge this back to earlier releases.

https://codereview.chromium.org/1883153003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp:163:
gl->FramebufferTexture2D(GL_FRAMEBUFFER, GL_DEPTH_STENCIL_ATTACHMENT,
GL_TEXTURE_2D, depthStencil, 0);
Could you please add a comment that the DEPTH_STENCIL synthetic attachment (it's
synthetic for ES 2.0, anyway) is being emulated for WebGL contexts at the
command buffer level?

A similar comment would be appropriate in DrawingBuffer::resizeDepthStencil,
Source/platform/graphics/gpu/DrawingBuffer.cpp.

Thanks.

[bajones, 2016-04-14 23:48:18]

Thanks for the feedback! Added the requested content.

On 2016/04/14 20:15:15, Zhenyao Mo wrote:
> "wtf/Assertions.h"
> why do you need this?

Whoops! That was for debug logging. Thanks for catching that!

[bajones, 2016-04-14 23:48:27]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-04-14 23:48:28]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1883153003/#ps20001
(title: "Addressed feedback")

[commit-bot: I haz the power, 2016-04-14 23:49:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883153003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883153003/20001

[commit-bot: I haz the power, 2016-04-15 01:39:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 01:39:25]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Russell (switch to Gerrit), 2016-04-15 20:53:45]

On 2016/04/15 01:39:25, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

The test passes on the same hardware running 10.11. I suggest adding a
suppression for (mac, nvidia, 0x0fe9), and 10.9, and let's move on.

[bajones, 2016-04-15 21:04:46]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-04-15 21:04:47]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1883153003/#ps40001
(title: "Expectation for single failing trybot")

[commit-bot: I haz the power, 2016-04-15 21:05:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883153003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883153003/40001

[commit-bot: I haz the power, 2016-04-15 23:27:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-15 23:28:52]

Description was changed from

==========
Fixed regression in WEBGL_draw_buffers support

The WebGLDrawBuffers::satisfiesWebGLRequirements check was relying on
Blink-side emulation of support for separate DEPTH and STENCIL targets,
which was removed and the logic pushed to the command buffer in an
earlier patch.

BUG=586536
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Fixed regression in WEBGL_draw_buffers support

The WebGLDrawBuffers::satisfiesWebGLRequirements check was relying on
Blink-side emulation of support for separate DEPTH and STENCIL targets,
which was removed and the logic pushed to the command buffer in an
earlier patch.

BUG=586536
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/fa81f67b9e865a3be27edd9b5d4593f04f3e1b2b
Cr-Commit-Position: refs/heads/master@{#387747}
==========

[commit-bot: I haz the power, 2016-04-15 23:28:54]

Patchset 3 (id:??) landed as
https://crrev.com/fa81f67b9e865a3be27edd9b5d4593f04f3e1b2b
Cr-Commit-Position: refs/heads/master@{#387747}