Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1883093002: Add support for generating the QtCreator projects from GN. (Closed)

Created:
4 years, 8 months ago by Krzysztof Olczyk
Modified:
4 years, 7 months ago
CC:
chromium-reviews, matthewtff_gmail.com, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for generating QtCreator projects from GN. This adds a new command line argument "--ide=" value to "gn gen" which, when specified, generates a QtCreator project. QtCreator is a quite powerful general-purpose (despite Qt in the name) IDE when developing on Linux system with code completion and navigation. Some interest in it has been demonstrated in the following thread: https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/9U4_ytjrah8 BUG= Committed: https://crrev.com/af72603e3cd01c17d98c3edf982b064516260bc6 Cr-Commit-Position: refs/heads/master@{#393514}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebased on HEAD, fixed issues. #

Total comments: 2

Patch Set 3 : Fixed compilation errors on Windows (paths in Windows :]) #

Total comments: 2

Patch Set 4 : Addressed the final comment #

Patch Set 5 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -3 lines) Patch
M tools/gn/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/command_gen.cc View 1 2 3 5 chunks +26 lines, -3 lines 2 comments Download
M tools/gn/gn.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/import_manager.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M tools/gn/import_manager.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
A tools/gn/qt_creator_writer.h View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A tools/gn/qt_creator_writer.cc View 1 2 1 chunk +174 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (13 generated)
Krzysztof Olczyk
Hi, could you please take a look at this CL related to https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/9U4_ytjrah8 discussion?
4 years, 8 months ago (2016-04-14 08:20:15 UTC) #2
brucedawson
I made some minor tweaks to the description, change back if you don't like them ...
4 years, 7 months ago (2016-05-09 18:56:49 UTC) #7
Krzysztof Olczyk
Thanks Bruce for the review. I have rebased the CL and addressed your comments. https://codereview.chromium.org/1883093002/diff/1/tools/gn/command_gen.cc ...
4 years, 7 months ago (2016-05-10 08:11:18 UTC) #8
brucedawson
lgtm
4 years, 7 months ago (2016-05-10 18:27:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883093002/20001
4 years, 7 months ago (2016-05-11 05:27:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/181057)
4 years, 7 months ago (2016-05-11 05:33:37 UTC) #13
Dirk Pranke
This looks basically okay, but I'd like to run this locally to look at the ...
4 years, 7 months ago (2016-05-11 15:36:37 UTC) #14
Krzysztof Olczyk
I have fixed the windows compilation problem and update docs as suggested. https://codereview.chromium.org/1883093002/diff/20001/tools/gn/command_gen.cc File tools/gn/command_gen.cc ...
4 years, 7 months ago (2016-05-12 06:37:07 UTC) #15
Dirk Pranke
https://codereview.chromium.org/1883093002/diff/40001/tools/gn/command_gen.cc File tools/gn/command_gen.cc (right): https://codereview.chromium.org/1883093002/diff/40001/tools/gn/command_gen.cc#newcode287 tools/gn/command_gen.cc:287: " Name of the target corresponding to \"All\" target ...
4 years, 7 months ago (2016-05-13 01:50:24 UTC) #16
Krzysztof Olczyk
https://codereview.chromium.org/1883093002/diff/40001/tools/gn/command_gen.cc File tools/gn/command_gen.cc (right): https://codereview.chromium.org/1883093002/diff/40001/tools/gn/command_gen.cc#newcode287 tools/gn/command_gen.cc:287: " Name of the target corresponding to \"All\" target ...
4 years, 7 months ago (2016-05-13 10:32:14 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883093002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883093002/80001
4 years, 7 months ago (2016-05-13 12:41:13 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 13:36:56 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883093002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883093002/80001
4 years, 7 months ago (2016-05-13 13:38:55 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-13 13:41:43 UTC) #26
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/af72603e3cd01c17d98c3edf982b064516260bc6 Cr-Commit-Position: refs/heads/master@{#393514}
4 years, 7 months ago (2016-05-13 13:44:32 UTC) #28
Dirk Pranke
https://codereview.chromium.org/1883093002/diff/80001/tools/gn/command_gen.cc File tools/gn/command_gen.cc (right): https://codereview.chromium.org/1883093002/diff/80001/tools/gn/command_gen.cc#newcode296 tools/gn/command_gen.cc:296: " the whole build graph will be omitted.\n" the ...
4 years, 7 months ago (2016-05-13 15:24:43 UTC) #29
brucedawson
https://codereview.chromium.org/1883093002/diff/80001/tools/gn/command_gen.cc File tools/gn/command_gen.cc (right): https://codereview.chromium.org/1883093002/diff/80001/tools/gn/command_gen.cc#newcode296 tools/gn/command_gen.cc:296: " the whole build graph will be omitted.\n" On ...
4 years, 7 months ago (2016-05-13 16:39:02 UTC) #30
Dirk Pranke
On 2016/05/13 16:39:02, brucedawson wrote: > Stupid English language. Whose idea was it to have ...
4 years, 7 months ago (2016-05-13 17:03:18 UTC) #31
Krzysztof Olczyk
On 2016/05/13 at 17:03:18, dpranke wrote: > On 2016/05/13 16:39:02, brucedawson wrote: > > Stupid ...
4 years, 7 months ago (2016-05-14 07:33:13 UTC) #32
Krzysztof Olczyk
4 years, 7 months ago (2016-05-14 07:56:14 UTC) #33
Message was sent while issue was closed.
On 2016/05/14 at 07:33:13, Krzysztof Olczyk wrote:
> On 2016/05/13 at 17:03:18, dpranke wrote:
> > On 2016/05/13 16:39:02, brucedawson wrote:
> > > Stupid English language. Whose idea was it to have a pair of words with
almost
> > > opposite meaning that differ by just one letter? Very poor design.
> > 
> > <dr. nick>inflammable means flammable? what a country!</dr. nick>
> 
> Ay. Sorry for the typo, will post a fixup.

I have created https://codereview.chromium.org/1979813002

Powered by Google App Engine
This is Rietveld 408576698