Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1979813002: Fix a typo in the gn gen help for QtCreator generator (introduced in https://codereview.chromium.or… (Closed)

Created:
4 years, 7 months ago by Krzysztof Olczyk
Modified:
4 years, 7 months ago
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a typo in the gn gen help for QtCreator generator (introduced in https://codereview.chromium.org/1883093002/) BUG= Committed: https://crrev.com/457e2cd70b7aeab763f7ee35bc60c62d36121c26 Cr-Commit-Position: refs/heads/master@{#393795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/command_gen.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Krzysztof Olczyk
4 years, 7 months ago (2016-05-14 07:55:55 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-14 16:07:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979813002/1
4 years, 7 months ago (2016-05-16 05:24:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 06:20:34 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 06:21:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/457e2cd70b7aeab763f7ee35bc60c62d36121c26
Cr-Commit-Position: refs/heads/master@{#393795}

Powered by Google App Engine
This is Rietveld 408576698