Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1882953004: [NTP Snippets] Add UMA for snippet dismissal (Closed)

Created:
4 years, 8 months ago by dgn
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer, rkaplow
CC:
chromium-reviews, mcwilliams+watch_chromium.org, asvitkine+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Add UMA for snippet dismissal BUG=603576 Committed: https://crrev.com/251cd6ed0d07b43de8cb4913e3a442be03d3dd98 Cr-Commit-Position: refs/heads/master@{#387576}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java View 1 2 chunks +5 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dgn
PTAL
4 years, 8 months ago (2016-04-14 15:13:51 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/1882953004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java (right): https://codereview.chromium.org/1882953004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java#newcode74 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java:74: /** A snippet as been swiped. */ Nit: ...
4 years, 8 months ago (2016-04-14 15:36:34 UTC) #3
rkaplow
lgtm agreement with bernhard comments, but lg otherwise
4 years, 8 months ago (2016-04-14 20:10:48 UTC) #4
dgn
Thanks! https://codereview.chromium.org/1882953004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java (right): https://codereview.chromium.org/1882953004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java#newcode74 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java:74: /** A snippet as been swiped. */ On ...
4 years, 8 months ago (2016-04-15 10:51:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882953004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882953004/20001
4 years, 8 months ago (2016-04-15 10:52:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 11:53:27 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 11:54:51 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/251cd6ed0d07b43de8cb4913e3a442be03d3dd98
Cr-Commit-Position: refs/heads/master@{#387576}

Powered by Google App Engine
This is Rietveld 408576698