Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1603)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

Issue 1882953004: [NTP Snippets] Add UMA for snippet dismissal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java
index fd4ca3d5b5c7d9d6288c60fef1ab6bef0683717f..245a3c456c67f607c92a2a1ddd71e317d91cb9db 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java
@@ -61,7 +61,8 @@
private static final int NUM_NTP_IMPRESSION = 2;
/** Possible interactions with the snippets. */
- @IntDef({SNIPPETS_ACTION_SHOWN, SNIPPETS_ACTION_SCROLLED, SNIPPETS_ACTION_CLICKED})
+ @IntDef({SNIPPETS_ACTION_SHOWN, SNIPPETS_ACTION_SCROLLED, SNIPPETS_ACTION_CLICKED,
+ SNIPPETS_ACTION_DISMISSED})
@Retention(RetentionPolicy.SOURCE)
public @interface SnippetsAction {}
/** Snippets are enabled and are being shown to the user. */
@@ -70,8 +71,10 @@
public static final int SNIPPETS_ACTION_SCROLLED = 1;
/** A snippet has been clicked. */
public static final int SNIPPETS_ACTION_CLICKED = 2;
+ /** A snippet has been swiped away. */
+ public static final int SNIPPETS_ACTION_DISMISSED = 3;
/** The number of possible actions. */
- private static final int NUM_SNIPPETS_ACTIONS = 3;
+ private static final int NUM_SNIPPETS_ACTIONS = 4;
/**
* Records an action taken by the user on the NTP.
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698