Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9017)

Unified Diff: chrome/installer/setup/install_worker.h

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: fix build error Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/install_worker.h
diff --git a/chrome/installer/setup/install_worker.h b/chrome/installer/setup/install_worker.h
index a2fc7f3b9318865ee5a86cc1d8ee72c71a193fdb..11d7e116f00b0e80cf23a1bf31c15b609b10c716 100644
--- a/chrome/installer/setup/install_worker.h
+++ b/chrome/installer/setup/install_worker.h
@@ -119,14 +119,13 @@ void AddInstallWorkItems(const InstallationState& original_state,
// |system_level| specifies whether to call the system or user level DLL
// registration entry points.
// |do_register| says whether to register or unregister.
-// |may_fail| states whether this is best effort or not. If |may_fail| is true
-// then |work_item_list| will still succeed if the registration fails and
-// no registration rollback will be performed.
+// If |best_effort| is true, registration or unregistration failure doesn't
+// cause failure of |work_item_list|.
void AddRegisterComDllWorkItems(const base::FilePath& dll_folder,
const std::vector<base::FilePath>& dll_files,
bool system_level,
bool do_register,
- bool ignore_failures,
+ bool best_effort,
WorkItemList* work_item_list);
void AddSetMsiMarkerWorkItem(const InstallerState& installer_state,

Powered by Google App Engine
This is Rietveld 408576698