Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4608)

Unified Diff: chrome/installer/setup/install.cc

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: fix build error Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/install.cc
diff --git a/chrome/installer/setup/install.cc b/chrome/installer/setup/install.cc
index af9662322892c2eaff4361005cd3f522f3cc7383..43a8ed24c7cd20bb00b3cb62f5f652e166e2e66a 100644
--- a/chrome/installer/setup/install.cc
+++ b/chrome/installer/setup/install.cc
@@ -756,9 +756,12 @@ void HandleActiveSetupForBrowser(const base::FilePath& installation_root,
bool force) {
DCHECK(chrome.is_chrome());
- NoRollbackWorkItemList cleanup_list;
- AddCleanupDeprecatedPerUserRegistrationsWorkItems(chrome, &cleanup_list);
- cleanup_list.Do();
+ std::unique_ptr<WorkItemList> cleanup_list(WorkItem::CreateWorkItemList());
+ cleanup_list->set_log_message("Cleanup deprecated per-user registrations");
+ cleanup_list->set_rollback_enabled(false);
+ cleanup_list->set_best_effort(true);
+ AddCleanupDeprecatedPerUserRegistrationsWorkItems(chrome, cleanup_list.get());
+ cleanup_list->Do();
// Only create shortcuts on Active Setup if the first run sentinel is not
// present for this user (as some shortcuts used to be installed on first

Powered by Google App Engine
This is Rietveld 408576698