chrome/installer/util/set_reg_value_work_item.h - Issue 1882923003: Add best-effort/allow rollback flags on WorkItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/set_reg_value_work_item.h

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/util/delete_tree_work_item.cc ('K') | « chrome/installer/util/self_reg_work_item.cc ('k') | chrome/installer/util/set_reg_value_work_item.cc » ('j') | chrome/installer/util/work_item.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/set_reg_value_work_item.h

diff --git a/chrome/installer/util/set_reg_value_work_item.h b/chrome/installer/util/set_reg_value_work_item.h

index 60104c4e9c89133231adac143a241456c73f498a..c8fdc2b8b935706915f49e46910e56f60fab0fe5 100644

--- a/chrome/installer/util/set_reg_value_work_item.h

+++ b/chrome/installer/util/set_reg_value_work_item.h

@@ -49,10 +49,6 @@ class SetRegValueWorkItem : public WorkItem {

~SetRegValueWorkItem() override;

- bool Do() override;

- void Rollback() override;

private:

enum SettingStatus {

// The status before Do is called.

@@ -70,6 +66,10 @@ class SetRegValueWorkItem : public WorkItem {

VALUE_ROLL_BACK

};

+ // WorkItem:

+ bool DoImpl() override;

+ void RollbackImpl() override;

// Root key of the target key under which the value is set. The root key can

// only be one of the predefined keys on Windows.

HKEY predefined_root_;