chrome/installer/util/self_reg_work_item.cc - Issue 1882923003: Add best-effort/allow rollback flags on WorkItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/self_reg_work_item.cc

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/util/delete_tree_work_item.cc ('K') | « chrome/installer/util/self_reg_work_item.h ('k') | chrome/installer/util/set_reg_value_work_item.h » ('j') | chrome/installer/util/work_item.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/self_reg_work_item.cc

diff --git a/chrome/installer/util/self_reg_work_item.cc b/chrome/installer/util/self_reg_work_item.cc

index 7157d6e4ae0935aeda063f4f17164bd329b0cd2d..dc7e722110626da20a0dae93b3d58ec5c1062cae 100644

--- a/chrome/installer/util/self_reg_work_item.cc

+++ b/chrome/installer/util/self_reg_work_item.cc

@@ -90,15 +90,10 @@ bool SelfRegWorkItem::RegisterDll(bool do_register) {

return success;

}

-bool SelfRegWorkItem::Do() {

- bool success = RegisterDll(do_register_);

- if (ignore_failure_)

- success = true;

- return success;

+bool SelfRegWorkItem::DoImpl() {

+ return RegisterDll(do_register_);

}

-void SelfRegWorkItem::Rollback() {

- if (!ignore_failure_) {

- RegisterDll(!do_register_);

- }

+void SelfRegWorkItem::RollbackImpl() {

+ RegisterDll(!do_register_);

}