third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-empty-srcset.html - Issue 1882893002: Remove the line-number flakiness by adding an img element dynamically.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-empty-srcset.html

Issue 1882893002: Remove the line-number flakiness by adding an img element dynamically. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-srcset-in-main-frame-blocked-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-srcset.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <img src="http://127.0.0.1:8080/security/resources/compass.jpg"

2 srcset>

3 <script>	1 <script>

4 window.onload = function() {	2 window.onload = function() {

5 if (window.opener)	3 var img = document.createElement('img');

6 window.opener.postMessage('done', '*');	4 img.src = "http://127.0.0.1:8080/security/resources/compass.jpg";

	5 img.srcset = "";
	Łukasz Anforowicz 2016/04/13 17:16:35 Please double-check. AFAICT this is equivalent to Please double-check. AFAICT this is equivalent to an attribute without a value in the deleted html: <img ... srcset>
	6 img.addEventListener('load', function () {

	7 if (window.opener)

	8 window.opener.postMessage('done', '*');

	9 });

	10 document.body.appendChild(img);

7 };	11 };

8 </script>	12 </script>

OLD	NEW