Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1882833005: Use hyphen for gerrit.skip-ensure-authenticated (Closed)

Created:
4 years, 8 months ago by shinyak
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use hyphen for gerrit.skip-ensure-authenticated git config key should consist of alphanumeric characters and '-'. The underscore '_' is not allowed. So we're getting 'invalid key' error when GERRIT_SKIP_ENSURE_AUTHENTICATED is set. Let's use '-' instead of '_'. BUG=603378 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M git_cl.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/git_cl_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
shinyak
4 years, 8 months ago (2016-04-15 04:19:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882833005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882833005/1
4 years, 8 months ago (2016-04-15 07:16:52 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 07:19:03 UTC) #8
tandrii(chromium)
Thanks! LGTM Oh, so much for test I wrote:(
4 years, 8 months ago (2016-04-15 07:21:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882833005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882833005/1
4 years, 8 months ago (2016-04-15 07:21:13 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 07:24:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299952

Powered by Google App Engine
This is Rietveld 408576698