git_cl.py - Issue 1882833005: Use hyphen for gerrit.skip-ensure-authenticated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 1882833005: Use hyphen for gerrit.skip-ensure-authenticated (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index eb66039a7154651415691a42cbfeb2a9960ad6eb..cf1e2c91093d9d73a21982b9336e1ce757b6a7ed 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -777,7 +777,7 @@ class Settings(object):

uploads."""

if self.gerrit_skip_ensure_authenticated is None:

self.gerrit_skip_ensure_authenticated = (

- RunGit(['config', '--bool', 'gerrit.skip_ensure_authenticated'],

+ RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],

error_ok=True).strip() == 'true')

return self.gerrit_skip_ensure_authenticated

@@ -2732,7 +2732,7 @@ def LoadCodereviewSettingsFromFile(fileobj):

keyvals['GERRIT_SQUASH_UPLOADS']])

if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:

- RunGit(['config', 'gerrit.skip_ensure_authenticated',

+ RunGit(['config', 'gerrit.skip-ensure-authenticated',

keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])

if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:

« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »