tools/android/loading Split GoogleAPI wrappers to a separate library

tools/android/loading Split GoogleAPI wrappers to a separate library

This is in preparation of the migration to a master/slave
architecture.

Committed: https://crrev.com/d452ab4c620c15a11333b36d8e5984248e158e35
Cr-Commit-Position: refs/heads/master@{#387873}

[droger, 2016-04-14 12:50:55]

Patchset #1 (id:1) has been deleted

[droger, 2016-04-14 16:21:33]

Description was changed from

==========
tools/android/loading Split GoogleAPI wrappers to a separate library
==========

to

==========
tools/android/loading Split GoogleAPI wrappers to a separate library

This is in preparation of the migration to a master/slave
architecture.
==========

[droger, 2016-04-14 16:21:43]

droger@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2016-04-15 13:21:49]

lgtm

https://codereview.chromium.org/1882793006/diff/20001/tools/android/loading/g...
File tools/android/loading/gce/google_api_util.py (right):

https://codereview.chromium.org/1882793006/diff/20001/tools/android/loading/g...
tools/android/loading/gce/google_api_util.py:9: class GoogleAPIUtil(object):
How about GoogleStorageAccessor?

https://codereview.chromium.org/1882793006/diff/20001/tools/android/loading/g...
tools/android/loading/gce/google_api_util.py:16: print 'Initializing
credentials'
Let's nix the print statement now that this is a library.

[droger, 2016-04-15 14:17:25]

https://codereview.chromium.org/1882793006/diff/20001/tools/android/loading/g...
File tools/android/loading/gce/google_api_util.py (right):

https://codereview.chromium.org/1882793006/diff/20001/tools/android/loading/g...
tools/android/loading/gce/google_api_util.py:9: class GoogleAPIUtil(object):
On 2016/04/15 13:21:49, blundell wrote:
> How about GoogleStorageAccessor?

I would like to add other wrappers for task queues later in this file.
So I need to keep the name somewhat generic.

An alternative would be to have a separate wrapper for the task queue API, but I
think it will share some code with this (in particular the authentication).

Let me know if you have a strong opinion.

[blundell, 2016-04-18 07:14:03]

On 2016/04/15 14:17:25, droger wrote:
>
https://codereview.chromium.org/1882793006/diff/20001/tools/android/loading/g...
> File tools/android/loading/gce/google_api_util.py (right):
> 
>
https://codereview.chromium.org/1882793006/diff/20001/tools/android/loading/g...
> tools/android/loading/gce/google_api_util.py:9: class GoogleAPIUtil(object):
> On 2016/04/15 13:21:49, blundell wrote:
> > How about GoogleStorageAccessor?
> 
> I would like to add other wrappers for task queues later in this file.
> So I need to keep the name somewhat generic.
> 
> An alternative would be to have a separate wrapper for the task queue API, but
I
> think it will share some code with this (in particular the authentication).
> 
> Let me know if you have a strong opinion.

I think it would be better to divide classes logically along their functionality
than have a grab bag. I suggest that we rename this to GoogleStorageAccessor and
then see how to refactor as necessary to appropriately share code when
introducing the wrappers around task queues.

[droger, 2016-04-18 08:01:10]

Patchset #3 (id:60001) has been deleted

[droger, 2016-04-18 08:01:54]

On 2016/04/18 07:14:03, blundell wrote:
> I think it would be better to divide classes logically along their
functionality
> than have a grab bag. I suggest that we rename this to GoogleStorageAccessor
and
> then see how to refactor as necessary to appropriately share code when
> introducing the wrappers around task queues.


Done.

[droger, 2016-04-18 08:01:59]

The CQ bit was checked by droger@chromium.org

[droger, 2016-04-18 08:01:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/1882793006/#ps80001
(title: "Review comments")

[commit-bot: I haz the power, 2016-04-18 08:02:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882793006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882793006/80001

[commit-bot: I haz the power, 2016-04-18 08:41:11]

Description was changed from

==========
tools/android/loading Split GoogleAPI wrappers to a separate library

This is in preparation of the migration to a master/slave
architecture.
==========

to

==========
tools/android/loading Split GoogleAPI wrappers to a separate library

This is in preparation of the migration to a master/slave
architecture.
==========

[commit-bot: I haz the power, 2016-04-18 08:41:12]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-04-18 08:42:40]

Description was changed from

==========
tools/android/loading Split GoogleAPI wrappers to a separate library

This is in preparation of the migration to a master/slave
architecture.
==========

to

==========
tools/android/loading Split GoogleAPI wrappers to a separate library

This is in preparation of the migration to a master/slave
architecture.

Committed: https://crrev.com/d452ab4c620c15a11333b36d8e5984248e158e35
Cr-Commit-Position: refs/heads/master@{#387873}
==========

[commit-bot: I haz the power, 2016-04-18 08:42:41]

Patchset 3 (id:??) landed as
https://crrev.com/d452ab4c620c15a11333b36d8e5984248e158e35
Cr-Commit-Position: refs/heads/master@{#387873}