tools/android/loading Add appengine frontend for Clovis

tools/android/loading Add appengine frontend for Clovis

Committed: https://crrev.com/0ee8eea8d5648db41fecddac32edca241d00fa44
Cr-Commit-Position: refs/heads/master@{#388229}

[droger, 2016-04-15 16:00:43]

Patchset #1 (id:1) has been deleted

[droger, 2016-04-15 16:00:50]

Patchset #1 (id:20001) has been deleted

[droger, 2016-04-15 16:00:56]

Patchset #1 (id:40001) has been deleted

[droger, 2016-04-15 16:09:12]

Patchset #1 (id:60001) has been deleted

[droger, 2016-04-15 16:09:19]

Patchset #1 (id:80001) has been deleted

[droger, 2016-04-15 16:49:50]

Patchset #1 (id:100001) has been deleted

[droger, 2016-04-15 16:53:34]

droger@chromium.org changed reviewers:
+ blundell@chromium.org

[droger, 2016-04-15 16:54:15]

Patchset #1 (id:120001) has been deleted

[droger, 2016-04-18 15:12:45]

Patchset #3 (id:180001) has been deleted

[blundell, 2016-04-19 11:05:25]

As a followup, I suggest that we use the following directory structure:

//tools/android/loading/cloud/{frontend, backend}

where .../backend is the code currently in //tools/android/loading/gce. Does
that make sense?

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
File tools/android/loading/frontend/README.md (right):

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/README.md:31: -   Add a `queue.yaml` file
defining a `clovis-queue` pull queue that can be
Where should this be added?

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/README.md:36: # queue.yaml
What exactly does this do?

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/README.md:47: # Install dependencies in the lib/
directory.
Will this pollute the local Chromium checkout?

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/README.md:55: ### Deploy
Add a section documenting the high-level organization (app.yaml file, how
clovis_frontend.py works, etc).

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
File tools/android/loading/frontend/clovis_frontend.py (right):

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/clovis_frontend.py:88: @app.route('/start',
methods=['POST'])
Why do we need this one?

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
File tools/android/loading/frontend/clovis_task.py (right):

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/clovis_task.py:15: action(str): Action
accomplished by this task..
nit: two periods

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/clovis_task.py:24: def FromJson(cls, json_dict):
nit: FromJsonDict

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/clovis_task.py:52: def ToJson(self):
nit: ToJsonDict

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
File tools/android/loading/frontend/static/form.html (right):

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/static/form.html:6: <title>Submmit new
batch</title>
nit: Submit

[droger, 2016-04-19 11:38:30]

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
File tools/android/loading/frontend/README.md (right):

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/README.md:31: -   Add a `queue.yaml` file
defining a `clovis-queue` pull queue that can be
On 2016/04/19 11:05:25, blundell wrote:
> Where should this be added?

Added some more comments.

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/README.md:36: # queue.yaml
On 2016/04/19 11:05:25, blundell wrote:
> What exactly does this do?

Added some more comments.

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/README.md:47: # Install dependencies in the lib/
directory.
On 2016/04/19 11:05:25, blundell wrote:
> Will this pollute the local Chromium checkout?

Yes. In particular this will make `git cl upload` extremely slow, because it
will try to run the linter over all the appengine code.

Unfortunately, I don't think there is a good way around it. The only think I can
think of would be to copy the directory elsewhere before running the commands.

Adding a paragraph explaining how to cleanup the repo.

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/README.md:55: ### Deploy
On 2016/04/19 11:05:25, blundell wrote:
> Add a section documenting the high-level organization (app.yaml file, how
> clovis_frontend.py works, etc).

Done.

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
File tools/android/loading/frontend/clovis_frontend.py (right):

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/clovis_frontend.py:88: @app.route('/start',
methods=['POST'])
On 2016/04/19 11:05:25, blundell wrote:
> Why do we need this one?

Not sure we need it. I added it because I thought it would be easier for adding
tasks programatically (using curl for example) instead of going through the web
interface.

Removed.

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
File tools/android/loading/frontend/clovis_task.py (right):

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/clovis_task.py:15: action(str): Action
accomplished by this task..
On 2016/04/19 11:05:25, blundell wrote:
> nit: two periods

Done.

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/clovis_task.py:24: def FromJson(cls, json_dict):
On 2016/04/19 11:05:25, blundell wrote:
> nit: FromJsonDict

Done.

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/clovis_task.py:52: def ToJson(self):
On 2016/04/19 11:05:25, blundell wrote:
> nit: ToJsonDict

Done.

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
File tools/android/loading/frontend/static/form.html (right):

https://codereview.chromium.org/1878943013/diff/220001/tools/android/loading/...
tools/android/loading/frontend/static/form.html:6: <title>Submmit new
batch</title>
On 2016/04/19 11:05:25, blundell wrote:
> nit: Submit

Done.

[droger, 2016-04-19 14:56:56]

Changed the directory structure.

According to:
https://cloud.google.com/appengine/docs/python/runtime#Python_Pure_Python
the way to include code from outside the application folder is to use a symlink,
and the appengine tools has logic to follow the symlinks and upload them.

[blundell, 2016-04-19 15:18:11]

lgtm

Let's add the blacklisted directory to .gitignore in its parent directory as
well.

[droger, 2016-04-19 15:49:18]

Thanks for the review.


On 2016/04/19 15:18:11, blundell (OOO until May 9) wrote:
> lgtm
> 
> Let's add the blacklisted directory to .gitignore in its parent directory as
> well.

Done

[droger, 2016-04-19 16:37:11]

The CQ bit was checked by droger@chromium.org

[droger, 2016-04-19 16:37:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/1878943013/#ps320001
(title: "Add gitignore")

[commit-bot: I haz the power, 2016-04-19 16:37:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878943013/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878943013/320001

[commit-bot: I haz the power, 2016-04-19 17:23:30]

Committed patchset #9 (id:320001)

[commit-bot: I haz the power, 2016-04-22 19:13:10]

Description was changed from

==========
tools/android/loading Add appengine frontend for Clovis
==========

to

==========
tools/android/loading Add appengine frontend for Clovis

Committed: https://crrev.com/0ee8eea8d5648db41fecddac32edca241d00fa44
Cr-Commit-Position: refs/heads/master@{#388229}
==========

[commit-bot: I haz the power, 2016-04-22 19:13:11]

Patchset 9 (id:??) landed as
https://crrev.com/0ee8eea8d5648db41fecddac32edca241d00fa44
Cr-Commit-Position: refs/heads/master@{#388229}