Re-enable tests for Non-SFI NaCl

Re-enable tests for Non-SFI NaCl

This reverts commit 46cfa62f3881df61ce65e843868a6c4801c3d6b5
(https://codereview.chromium.org/1662283002), with an addition change
to leave these tests disabled under ASan and other sanitizers since
they don't pass there.

The Non-SFI NaCl tests were disabled because of a one-off failure.
It's not known what the cause of that failure was, but the tests don't
fail at the moment.

BUG=579804
TEST=browser_tests

Committed: https://crrev.com/4a08b3a4f646f4a52d26af9b191d034b6534f048
Cr-Commit-Position: refs/heads/master@{#425521}

[Mark Seaborn, 2016-04-13 05:25:48]

The CQ bit was checked by mseaborn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 05:26:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882753002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882753002/1

[commit-bot: I haz the power, 2016-04-13 06:11:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 06:11:11]

Dry run: This issue passed the CQ dry run.

[Mark Seaborn, 2016-10-13 01:14:45]

The CQ bit was checked by mseaborn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 01:14:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 03:41:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 03:41:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Seaborn, 2016-10-13 20:42:53]

Description was changed from

==========
Revert "Disabling some NaCl-related tests on Linux for flakiness"

This reverts commit 46cfa62f3881df61ce65e843868a6c4801c3d6b5.

BUG=
==========

to

==========
Re-enable tests for Non-SFI NaCl

This reverts commit 46cfa62f3881df61ce65e843868a6c4801c3d6b5
(https://codereview.chromium.org/1662283002).

The Non-SFI NaCl tests were disabled because of a one-off failure.
It's not known what the cause of that failure was, but the tests don't
fail at the moment.

BUG=579804
TEST=browser_tests
==========

[Mark Seaborn, 2016-10-13 20:42:53]

mseaborn@chromium.org changed reviewers:
+ sammc@chromium.org

[Mark Seaborn, 2016-10-13 20:48:06]

@sammc: I'd like to re-enable these tests before your Mojo-related change is
landed (https://codereview.chromium.org/2301103003/), to make sure that the use
of Mojo doesn't break Non-SFI mode.

[Sam McNally, 2016-10-13 21:11:40]

LGTM

https://codereview.chromium.org/1882753002/diff/1/chrome/test/nacl/nacl_brows...
File chrome/test/nacl/nacl_browsertest_util.h (right):

https://codereview.chromium.org/1882753002/diff/1/chrome/test/nacl/nacl_brows...
chrome/test/nacl/nacl_browsertest_util.h:200: (defined(ARCH_CPU_X86_FAMILY) ||
defined(ARCH_CPU_ARMEL))
Given the ASAN bot failures, I'm guessing this needs the sanitizer ifdefs from
above.

[Mark Seaborn, 2016-10-14 19:34:02]

https://codereview.chromium.org/1882753002/diff/1/chrome/test/nacl/nacl_brows...
File chrome/test/nacl/nacl_browsertest_util.h (right):

https://codereview.chromium.org/1882753002/diff/1/chrome/test/nacl/nacl_brows...
chrome/test/nacl/nacl_browsertest_util.h:200: (defined(ARCH_CPU_X86_FAMILY) ||
defined(ARCH_CPU_ARMEL))
On 2016/10/13 21:11:40, Sam McNally wrote:
> Given the ASAN bot failures, I'm guessing this needs the sanitizer ifdefs from
> above.

I'm not sure what's going on with those ASAN bot failures, because they're also
showing failures in tests for SFI NaCl (e.g. "PPAPINaClPNaClTest.Core"), not
just Non-SFI NaCl.  And I don't see how this change can be enabling SFI NaCl
tests on ASAN...

[Mark Seaborn, 2016-10-15 00:10:46]

Description was changed from

==========
Re-enable tests for Non-SFI NaCl

This reverts commit 46cfa62f3881df61ce65e843868a6c4801c3d6b5
(https://codereview.chromium.org/1662283002).

The Non-SFI NaCl tests were disabled because of a one-off failure.
It's not known what the cause of that failure was, but the tests don't
fail at the moment.

BUG=579804
TEST=browser_tests
==========

to

==========
Re-enable tests for Non-SFI NaCl

This reverts commit 46cfa62f3881df61ce65e843868a6c4801c3d6b5
(https://codereview.chromium.org/1662283002), with an addition change
to leave these tests disabled under ASan and other sanitizers since
they don't pass there.

The Non-SFI NaCl tests were disabled because of a one-off failure.
It's not known what the cause of that failure was, but the tests don't
fail at the moment.

BUG=579804
TEST=browser_tests
==========

[Mark Seaborn, 2016-10-15 00:12:43]

https://codereview.chromium.org/1882753002/diff/1/chrome/test/nacl/nacl_brows...
File chrome/test/nacl/nacl_browsertest_util.h (right):

https://codereview.chromium.org/1882753002/diff/1/chrome/test/nacl/nacl_brows...
chrome/test/nacl/nacl_browsertest_util.h:200: (defined(ARCH_CPU_X86_FAMILY) ||
defined(ARCH_CPU_ARMEL))
On 2016/10/14 19:34:02, Mark Seaborn wrote:
> On 2016/10/13 21:11:40, Sam McNally wrote:
> > Given the ASAN bot failures, I'm guessing this needs the sanitizer
> > ifdefs from above.

OK, done.

> I'm not sure what's going on with those ASAN bot failures, because they're
also
> showing failures in tests for SFI NaCl (e.g. "PPAPINaClPNaClTest.Core"), not
> just Non-SFI NaCl.  And I don't see how this change can be enabling SFI NaCl
> tests on ASAN...

I think that was an unrelated flake, maybe caused by https://crbug.com/633067. 
It went away when I ran the trybot again.

[Mark Seaborn, 2016-10-15 00:12:48]

The CQ bit was checked by mseaborn@chromium.org

[Mark Seaborn, 2016-10-15 00:12:49]

The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org
Link to the patchset: https://codereview.chromium.org/1882753002/#ps20001
(title: "Disable under sanitizers")

[commit-bot: I haz the power, 2016-10-15 00:13:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 01:02:56]

Description was changed from

==========
Re-enable tests for Non-SFI NaCl

This reverts commit 46cfa62f3881df61ce65e843868a6c4801c3d6b5
(https://codereview.chromium.org/1662283002), with an addition change
to leave these tests disabled under ASan and other sanitizers since
they don't pass there.

The Non-SFI NaCl tests were disabled because of a one-off failure.
It's not known what the cause of that failure was, but the tests don't
fail at the moment.

BUG=579804
TEST=browser_tests
==========

to

==========
Re-enable tests for Non-SFI NaCl

This reverts commit 46cfa62f3881df61ce65e843868a6c4801c3d6b5
(https://codereview.chromium.org/1662283002), with an addition change
to leave these tests disabled under ASan and other sanitizers since
they don't pass there.

The Non-SFI NaCl tests were disabled because of a one-off failure.
It's not known what the cause of that failure was, but the tests don't
fail at the moment.

BUG=579804
TEST=browser_tests
==========

[commit-bot: I haz the power, 2016-10-15 01:02:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-15 01:04:50]

Description was changed from

==========
Re-enable tests for Non-SFI NaCl

This reverts commit 46cfa62f3881df61ce65e843868a6c4801c3d6b5
(https://codereview.chromium.org/1662283002), with an addition change
to leave these tests disabled under ASan and other sanitizers since
they don't pass there.

The Non-SFI NaCl tests were disabled because of a one-off failure.
It's not known what the cause of that failure was, but the tests don't
fail at the moment.

BUG=579804
TEST=browser_tests
==========

to

==========
Re-enable tests for Non-SFI NaCl

This reverts commit 46cfa62f3881df61ce65e843868a6c4801c3d6b5
(https://codereview.chromium.org/1662283002), with an addition change
to leave these tests disabled under ASan and other sanitizers since
they don't pass there.

The Non-SFI NaCl tests were disabled because of a one-off failure.
It's not known what the cause of that failure was, but the tests don't
fail at the moment.

BUG=579804
TEST=browser_tests

Committed: https://crrev.com/4a08b3a4f646f4a52d26af9b191d034b6534f048
Cr-Commit-Position: refs/heads/master@{#425521}
==========

[commit-bot: I haz the power, 2016-10-15 01:04:51]

Patchset 2 (id:??) landed as
https://crrev.com/4a08b3a4f646f4a52d26af9b191d034b6534f048
Cr-Commit-Position: refs/heads/master@{#425521}