Re-enable tests for Non-SFI NaCl

chrome/test/nacl/nacl_browsertest_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
 #define CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
 
 #include <memory>
 
 #include "base/files/file_path.h"
@@ skipping 178 matching lines @@
     !defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER) && \
     !defined(LEAK_SANITIZER) && \
     (defined(ARCH_CPU_X86) || defined(ARCH_CPU_ARMEL))
 #  define MAYBE_NONSFI(test_case) test_case
 #else
 #  define MAYBE_NONSFI(test_case) DISABLED_##test_case
 #endif
 
 // Similar to MAYBE_NONSFI, this is available only on x86-32, x86-64 or
 // ARM linux.
-// TODO(crbug.com/579804) -- tests disabled on Linux for flakiness.
 #if defined(OS_LINUX) && \
     (defined(ARCH_CPU_X86_FAMILY) || defined(ARCH_CPU_ARMEL))

[Sam McNally, 2016/10/13 21:11:40]

Given the ASAN bot failures, I'm guessing this needs the sanitizer ifdefs from
above.

[Mark Seaborn, 2016/10/14 19:34:02]

I'm not sure what's going on with those ASAN bot failures, because they're also
showing failures in tests for SFI NaCl (e.g. "PPAPINaClPNaClTest.Core"), not
just Non-SFI NaCl.  And I don't see how this change can be enabling SFI NaCl
tests on ASAN...

[Mark Seaborn, 2016/10/15 00:12:43]

OK, done.
I think that was an unrelated flake, maybe caused by https://crbug.com/633067. 
It went away when I ran the trybot again.

-#  define MAYBE_PNACL_NONSFI(test_case) DISABLED_##test_case
+#  define MAYBE_PNACL_NONSFI(test_case) test_case
 #else
 #  define MAYBE_PNACL_NONSFI(test_case) DISABLED_##test_case
 #endif
 
 
 #define NACL_BROWSER_TEST_F(suite, name, body) \
 IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \
 body \
 IN_PROC_BROWSER_TEST_F(suite##GLibc, MAYBE_GLIBC(name)) \
 body \
 IN_PROC_BROWSER_TEST_F(suite##Pnacl, MAYBE_PNACL(name)) \
 body
 
 #endif  // CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_