third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash.html - Issue 1882583002: Convert track tests from video-test.js to testharness.js based

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash.html

Issue 1882583002: Convert track tests from video-test.js to testharness.js based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html ('K') | « third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position-expected.txt ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash.html b/third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash.html

index 3c6ad4d61d2b8b8fd2dfbd7b93440d15c03146d0..ea6534d2ad7738366dcae18ec05a3de4e4057841 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash.html

@@ -1,36 +1,18 @@

<!DOCTYPE html>

-<html>

- <head>

- <script src=../media-file.js></script>

- <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

- (Please avoid writing new tests using video-test.js) -->

- <script src=../video-test.js></script>

- <script>

- var fragment;

- function startTest()

- {

- var emptyCue = new VTTCue(0, 0, "");

- fragment = emptyCue.getCueAsHTML();

+<title>Tests that having an empty cue does not crash when calling getCueAsHTML().</title>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script>

+test(function() {

+ var emptyCue = new VTTCue(0, 0, "");

+ var fragment = emptyCue.getCueAsHTML();

- consoleWrite("** The getCueAsHTML() method should return a document fragment **");

- testExpected("fragment", null, "!=");

+ // The getCueAsHTML() method should return a document fragment.

+ assert_not_equals(fragment, null);

philipj_slow 2016/04/15 14:04:50 Maybe assert fragment instanceof DocumentFragment

Srirama 2016/04/16 06:44:32 Done.

- consoleWrite("<br>** The document fragment should have one child, an empty Text node **");

- testExpected("fragment.childNodes.length", 1);

- testExpected("fragment.childNodes[0].constructor.name", Text.name);

- testExpected("fragment.childNodes[0].length", 0);

- consoleWrite("");

- consoleWrite("No crash. PASS.");

- consoleWrite("");

- endTest();

- }

- </script>

- </head>

- <body onload="startTest()">

- <p>Tests that having an empty cue does not crash when calling getCueAsHTML().</p>

- <video controls />

- </body>

-</html>

+ // The document fragment should have one child, an empty Text node.

+ assert_equals(fragment.childNodes.length, 1);

+ assert_equals(fragment.childNodes[0].constructor.name, Text.name);

+ assert_equals(fragment.childNodes[0].length, 0);

philipj_slow 2016/04/15 14:04:50 maybe assert_equals(fragment.childNodes[0].data, "

Srirama 2016/04/16 06:44:32 Done. So you want it as additional condition? Or y

+});

+</script>