third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash.html - Issue 1882583002: Convert track tests from video-test.js to testharness.js based

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash.html

Issue 1882583002: Convert track tests from video-test.js to testharness.js based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html ('K') | « third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position-expected.txt ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-empty-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <title>Tests that having an empty cue does not crash when calling getCueAsHTML() .</title>

3 <head>	3 <script src="../../resources/testharness.js"></script>

4 <script src=../media-file.js></script>	4 <script src="../../resources/testharnessreport.js"></script>

5 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	5 <script>

6 (Please avoid writing new tests using video-test.js) -->	6 test(function() {

7 <script src=../video-test.js></script>	7 var emptyCue = new VTTCue(0, 0, "");

8 <script>	8 var fragment = emptyCue.getCueAsHTML();

9 var fragment;

10 function startTest()

11 {

12 var emptyCue = new VTTCue(0, 0, "");

13 fragment = emptyCue.getCueAsHTML();

14	9

15 consoleWrite(" The getCueAsHTML() method should return a document fragment ");	10 // The getCueAsHTML() method should return a document fragment.

16 testExpected("fragment", null, "!=");	11 assert_not_equals(fragment, null);
	philipj_slow 2016/04/15 14:04:50 Maybe assert fragment instanceof DocumentFragment Maybe assert fragment instanceof DocumentFragment instead? Srirama 2016/04/16 06:44:32 Done. Show quoted text On 2016/04/15 14:04:50, philipj_slow wrote: > Maybe assert fragment instanceof DocumentFragment instead? Done.
17	12

18 consoleWrite("<br> The document fragment should have one child, an empty Text node ");	13 // The document fragment should have one child, an empty Text node.

19 testExpected("fragment.childNodes.length", 1);	14 assert_equals(fragment.childNodes.length, 1);

20 testExpected("fragment.childNodes[0].constructor.name", Text.name);	15 assert_equals(fragment.childNodes[0].constructor.name, Text.name);

21 testExpected("fragment.childNodes[0].length", 0);	16 assert_equals(fragment.childNodes[0].length, 0);
	philipj_slow 2016/04/15 14:04:50 maybe assert_equals(fragment.childNodes[0].data, " maybe assert_equals(fragment.childNodes[0].data, "")? If it did fail, the message would tell you what the string actually is then. Srirama 2016/04/16 06:44:32 Done. So you want it as additional condition? Or y Show quoted text On 2016/04/15 14:04:50, philipj_slow wrote: > maybe assert_equals(fragment.childNodes[0].data, "")? If it did fail, the > message would tell you what the string actually is then. Done. So you want it as additional condition? Or you want to replace any of the above two conditions?
22	17 });

23 consoleWrite("");	18 </script>

24 consoleWrite("No crash. PASS.");

25 consoleWrite("");

26

27 endTest();

28 }

29 </script>

30 </head>

31

32 <body onload="startTest()">

33 <p>Tests that having an empty cue does not crash when calling getCueAsHT ML().</p>

34 <video controls />

35 </body>

36 </html>

OLD	NEW