A64: Record the size of veneer pools for code offset mapping.

A64: Record the size of veneer pools for code offset mapping.

Mapping the code offsets between code with and without debug break slots
requires information about the size of the veneer pools and constant pools.

BUG=v8:3173
LOG=N
R=ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=19857

[ulan, 2014-03-07 10:51:56]

Looks good. One question:

https://codereview.chromium.org/188253005/diff/1/src/a64/assembler-a64.cc
File src/a64/assembler-a64.cc (right):

https://codereview.chromium.org/188253005/diff/1/src/a64/assembler-a64.cc#new...
src/a64/assembler-a64.cc:2678: RelocInfo::VENEER_POOL,
static_cast<intptr_t>(pool_size),
Are there test checking that we read the size correctly in disassembler or
debugger?

[Alexandre Rames, 2014-03-07 16:59:24]

On 2014/03/07 10:51:56, ulan wrote:
> Looks good. One question:
> 
> https://codereview.chromium.org/188253005/diff/1/src/a64/assembler-a64.cc
> File src/a64/assembler-a64.cc (right):
> 
>
https://codereview.chromium.org/188253005/diff/1/src/a64/assembler-a64.cc#new...
> src/a64/assembler-a64.cc:2678: RelocInfo::VENEER_POOL,
> static_cast<intptr_t>(pool_size),
> Are there test checking that we read the size correctly in disassembler or
> debugger?

There were debugger tests implicitly testing it. I added a simple test for this.
I also fixed the assembler to only record the veneer pool size when debugger
support is required.

[Alexandre Rames, 2014-03-07 17:00:29]

On 2014/03/07 16:59:24, Alexandre Rames wrote:
> On 2014/03/07 10:51:56, ulan wrote:
> > Looks good. One question:
> > 
> > https://codereview.chromium.org/188253005/diff/1/src/a64/assembler-a64.cc
> > File src/a64/assembler-a64.cc (right):
> > 
> >
>
https://codereview.chromium.org/188253005/diff/1/src/a64/assembler-a64.cc#new...
> > src/a64/assembler-a64.cc:2678: RelocInfo::VENEER_POOL,
> > static_cast<intptr_t>(pool_size),
> > Are there test checking that we read the size correctly in disassembler or
> > debugger?
> 
> There were debugger tests implicitly testing it. I added a simple test for
this.
> I also fixed the assembler to only record the veneer pool size when debugger
> support is required.

(I fixed the tests for this recently in r19350)

[ulan, 2014-03-11 09:00:20]

Thanks for adding the test, lgtm!

[Alexandre Rames, 2014-03-12 15:40:49]

Committed patchset #2 manually as r19857 (presubmit successful).