Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: net/ssl/channel_id_service.cc

Issue 1882433002: Removing NSS files and USE_OPENSSL flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_server_socket_unittest.cc ('k') | net/ssl/ssl_cipher_suite_names.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/channel_id_service.cc
diff --git a/net/ssl/channel_id_service.cc b/net/ssl/channel_id_service.cc
index 163a56b2977c8f99f0a6cdbe1822aad450dfda9d..830a4a438b470a8b3368391b07a967742324fcf6 100644
--- a/net/ssl/channel_id_service.cc
+++ b/net/ssl/channel_id_service.cc
@@ -31,10 +31,6 @@
#include "net/cert/x509_util.h"
#include "url/gurl.h"
-#if !defined(USE_OPENSSL)
-#include <private/pprthred.h> // PR_DetachThread
-#endif
-
namespace net {
namespace {
@@ -146,16 +142,6 @@ class ChannelIDServiceWorker {
int error = ERR_FAILED;
std::unique_ptr<ChannelIDStore::ChannelID> channel_id =
GenerateChannelID(server_identifier_, &error);
-#if !defined(USE_OPENSSL)
- // Detach the thread from NSPR.
- // Calling NSS functions attaches the thread to NSPR, which stores
- // the NSPR thread ID in thread-specific data.
- // The threads in our thread pool terminate after we have called
- // PR_Cleanup. Unless we detach them from NSPR, net_unittests gets
- // segfaults on shutdown when the threads' thread-specific data
- // destructors run.
- PR_DetachThread();
-#endif
origin_task_runner_->PostTask(
FROM_HERE, base::Bind(callback_, server_identifier_, error,
base::Passed(&channel_id)));
« no previous file with comments | « net/socket/ssl_server_socket_unittest.cc ('k') | net/ssl/ssl_cipher_suite_names.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698