Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: net/socket/ssl_server_socket_unittest.cc

Issue 1882433002: Removing NSS files and USE_OPENSSL flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_server_socket_nss.cc ('k') | net/ssl/channel_id_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_server_socket_unittest.cc
diff --git a/net/socket/ssl_server_socket_unittest.cc b/net/socket/ssl_server_socket_unittest.cc
index 74e06abfaf6cddd1fd43d947dbba439a84d7102f..32ecfc0fdca382e6f1db587086408de096e5ea4d 100644
--- a/net/socket/ssl_server_socket_unittest.cc
+++ b/net/socket/ssl_server_socket_unittest.cc
@@ -20,6 +20,10 @@
#include <queue>
#include <utility>
+#include <openssl/evp.h>
+#include <openssl/ssl.h>
+#include <openssl/x509.h>
+
#include "base/callback_helpers.h"
#include "base/compiler_specific.h"
#include "base/files/file_path.h"
@@ -65,12 +69,6 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
-#if defined(USE_OPENSSL)
-#include <openssl/evp.h>
-#include <openssl/ssl.h>
-#include <openssl/x509.h>
-#endif
-
namespace net {
namespace {
@@ -397,7 +395,6 @@ class SSLServerSocketTest : public PlatformTest {
ASSERT_TRUE(server_socket_);
}
-#if defined(USE_OPENSSL)
void ConfigureClientCertsForClient(const char* cert_file_name,
const char* private_key_file_name) {
client_ssl_config_.send_client_cert = true;
@@ -458,7 +455,6 @@ class SSLServerSocketTest : public PlatformTest {
crypto::RSAPrivateKey::CreateFromPrivateKeyInfo(key_vector));
return key;
}
-#endif
std::unique_ptr<FakeDataChannel> channel_1_;
std::unique_ptr<FakeDataChannel> channel_2_;
@@ -520,9 +516,6 @@ TEST_F(SSLServerSocketTest, Handshake) {
EXPECT_TRUE(is_aead);
}
-// NSS ports don't support client certificates and have a global session cache.
-#if defined(USE_OPENSSL)
-
// This test makes sure the session cache is working.
TEST_F(SSLServerSocketTest, HandshakeCached) {
ASSERT_NO_FATAL_FAILURE(CreateContext());
@@ -865,7 +858,6 @@ TEST_F(SSLServerSocketTest, HandshakeWithWrongClientCertSuppliedCached) {
EXPECT_EQ(ERR_BAD_SSL_CLIENT_AUTH_CERT,
handshake_callback2.GetResult(server_ret2));
}
-#endif // defined(USE_OPENSSL)
TEST_F(SSLServerSocketTest, DataTransfer) {
ASSERT_NO_FATAL_FAILURE(CreateContext());
« no previous file with comments | « net/socket/ssl_server_socket_nss.cc ('k') | net/ssl/channel_id_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698