Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 1882413004: Fix an issue that download file is not deleted when clicking Replace button (Closed)

Created:
4 years, 8 months ago by qinmin
Modified:
4 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix an issue that download file is not deleted when clicking Replace button When enqueueing a file to Android DownloadManager, we delete the file if user choose to overwrite. But when using Chrome's network stack, we didn't remove the file. This will reduce user's sdcard space during download. And it also causes issues when user try to resume the download. This CL deletes the file when user clicks the "Replace File" button. TBR=yfriedman@chromium.org BUG=602721 Review URL: https://codereview.chromium.org/1884783002 Cr-Commit-Position: refs/heads/master@{#387368} (cherry picked from commit c0258fd32bb4bda3ab721d426c3c4a73177af861) Committed: https://chromium.googlesource.com/chromium/src/+/d3fbb31663558ab79ed42d101bd0cb8587c5cea3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
4 years, 8 months ago (2016-04-14 19:27:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d3fbb31663558ab79ed42d101bd0cb8587c5cea3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698