Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1884783002: Fix an issue that download file is not deleted when clicking Replace button (Closed)

Created:
4 years, 8 months ago by qinmin
Modified:
4 years, 8 months ago
Reviewers:
Yaron, Changwan Ryu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that download file is not deleted when clicking Replace button When enqueueing a file to Android DownloadManager, we delete the file if user choose to overwrite. But when using Chrome's network stack, we didn't remove the file. This will reduce user's sdcard space during download. And it also causes issues when user try to resume the download. This CL deletes the file when user clicks the "Replace File" button. BUG=602721 Committed: https://crrev.com/c0258fd32bb4bda3ab721d426c3c4a73177af861 Cr-Commit-Position: refs/heads/master@{#387368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
qinmin
PTAL
4 years, 8 months ago (2016-04-12 20:59:01 UTC) #2
Changwan Ryu
lgtm
4 years, 8 months ago (2016-04-14 00:57:20 UTC) #3
qinmin
+yfriedman for OWNER
4 years, 8 months ago (2016-04-14 17:01:38 UTC) #5
Yaron
lgtm
4 years, 8 months ago (2016-04-14 17:27:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884783002/1
4 years, 8 months ago (2016-04-14 17:37:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 18:16:16 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 18:18:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0258fd32bb4bda3ab721d426c3c4a73177af861
Cr-Commit-Position: refs/heads/master@{#387368}

Powered by Google App Engine
This is Rietveld 408576698