TaskScheduler: Remove wake up callback from PriorityQueue.

TaskScheduler: Remove wake up callback from PriorityQueue.

We will call a wake up method explicitly after pushing a Sequence in
a PriorityQueue instead of relying on a callback to do it
automatically.

BUG=553459
Committed: https://crrev.com/2ce5469c8f861b74dd6242e0231c2f71d1d9a3c4
Cr-Commit-Position: refs/heads/master@{#387492}

[fdoray, 2016-04-13 13:48:00]

fdoray@chromium.org changed reviewers:
+ danakj@chromium.org, gab@chromium.org, robliao@chromium.org

[fdoray, 2016-04-13 13:48:01]

Can you review this CL? Thanks.

[robliao, 2016-04-13 17:22:52]

https://codereview.chromium.org/1882293004/diff/1/base/task_scheduler/priorit...
File base/task_scheduler/priority_queue.h (right):

https://codereview.chromium.org/1882293004/diff/1/base/task_scheduler/priorit...
base/task_scheduler/priority_queue.h:59: void
Push(std::unique_ptr<SequenceAndSortKey> sequence_and_sort_key);
To document the design expectation, we're going to keep the
SchedulerThreadPool::WakeUpOneThread self contained, correct?

https://codereview.chromium.org/1882293004/diff/1/base/task_scheduler/priorit...
base/task_scheduler/priority_queue.h:83: // Default constructor.
Comment not required. It's pretty clear from here.

[fdoray, 2016-04-13 17:43:34]

https://codereview.chromium.org/1882293004/diff/1/base/task_scheduler/priorit...
File base/task_scheduler/priority_queue.h (right):

https://codereview.chromium.org/1882293004/diff/1/base/task_scheduler/priorit...
base/task_scheduler/priority_queue.h:59: void
Push(std::unique_ptr<SequenceAndSortKey> sequence_and_sort_key);
On 2016/04/13 17:22:51, robliao wrote:
> To document the design expectation, we're going to keep the
> SchedulerThreadPool::WakeUpOneThread self contained, correct?

Correct. SchedulerThreadPool::WakeUpOneThread is a private method that will only
be called from SchedulerThreadPool::PostTaskNow and
SchedulerThreadPool::EnqueueSequence.

https://codereview.chromium.org/1882293004/diff/1/base/task_scheduler/priorit...
base/task_scheduler/priority_queue.h:83: // Default constructor.
On 2016/04/13 17:22:51, robliao wrote:
> Comment not required. It's pretty clear from here.

Done.

[danakj, 2016-04-13 18:07:52]

LGTM

[robliao, 2016-04-13 20:09:59]

lgtm

[gab, 2016-04-14 15:06:32]

The CQ bit was checked by gab@chromium.org

[gab, 2016-04-14 15:06:33]

lgtm

[commit-bot: I haz the power, 2016-04-14 15:06:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882293004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882293004/20001

[gab, 2016-04-14 15:06:56]

The CQ bit was unchecked by gab@chromium.org

[fdoray, 2016-04-14 22:10:17]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-04-14 22:10:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882293004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882293004/20001

[commit-bot: I haz the power, 2016-04-14 22:23:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 22:23:03]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[fdoray, 2016-04-14 23:41:50]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-04-14 23:42:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882293004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882293004/20001

[commit-bot: I haz the power, 2016-04-15 00:42:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-15 00:45:39]

Description was changed from

==========
TaskScheduler: Remove wake up callback from PriorityQueue.

We will call a wake up method explicitly after pushing a Sequence in
a PriorityQueue instead of relying on a callback to do it
automatically.

BUG=553459
==========

to

==========
TaskScheduler: Remove wake up callback from PriorityQueue.

We will call a wake up method explicitly after pushing a Sequence in
a PriorityQueue instead of relying on a callback to do it
automatically.

BUG=553459

Committed: https://crrev.com/2ce5469c8f861b74dd6242e0231c2f71d1d9a3c4
Cr-Commit-Position: refs/heads/master@{#387492}
==========

[commit-bot: I haz the power, 2016-04-15 00:45:40]

Patchset 2 (id:??) landed as
https://crrev.com/2ce5469c8f861b74dd6242e0231c2f71d1d9a3c4
Cr-Commit-Position: refs/heads/master@{#387492}