Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1869393002: TaskScheduler: Remove OnMainExit from SchedulerWorkerThread::Delegate. (Closed)

Created:
4 years, 8 months ago by fdoray
Modified:
4 years, 8 months ago
Reviewers:
gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@5b_enqueue
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TaskScheduler: Remove OnMainExit from SchedulerWorkerThread::Delegate. We planned to used this method to reset TLS, but we realized that this is done automatically. BUG=553459 Committed: https://crrev.com/73e26dbb8c32c4122a80e04a292b409b7a1991d8 Cr-Commit-Position: refs/heads/master@{#386202}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M base/task_scheduler/scheduler_worker_thread.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/task_scheduler/scheduler_worker_thread.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M base/task_scheduler/scheduler_worker_thread_unittest.cc View 1 2 3 chunks +0 lines, -17 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
fdoray
gab@: Can you review this CL? Thanks.
4 years, 8 months ago (2016-04-08 14:25:29 UTC) #2
gab
lgtm
4 years, 8 months ago (2016-04-08 15:54:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869393002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869393002/40001
4 years, 8 months ago (2016-04-08 20:10:54 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-08 21:16:22 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 21:17:44 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/73e26dbb8c32c4122a80e04a292b409b7a1991d8
Cr-Commit-Position: refs/heads/master@{#386202}

Powered by Google App Engine
This is Rietveld 408576698