🏨 Switch Android gtests to use generated wrapper scripts

Switch Android gtests to use generated wrapper scripts

BUG=599919
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299863

[agrieve, 2016-04-12 15:59:05]

Description was changed from

==========
Switch Android gtests to user generated wrapper scripts

BUG=599919
==========

to

==========
Switch Android gtests to user generated wrapper scripts

BUG=599919
==========

[agrieve, 2016-04-12 15:59:05]

agrieve@chromium.org changed reviewers:
+ kjellander@chromium.org, mikecase@chromium.org, xunjieli@chromium.org

[agrieve, 2016-04-12 15:59:16]

Description was changed from

==========
Switch Android gtests to user generated wrapper scripts

BUG=599919
==========

to

==========
Switch Android gtests to use generated wrapper scripts

BUG=599919
==========

[agrieve, 2016-04-12 15:59:55]

mikecase@chromium.org: Main android changes

xunjieli@chromium.org: cronet concerns?

kjellander@chromium.org: webrtc concerns?

[xunjieli, 2016-04-12 16:37:20]

cronet lgtm

[kjellander_chromium, 2016-04-12 16:46:24]

lgtm! 
The shard_timeout parameter can probably be removed, but that can be done in a
separate CL.

I can take care of cleaning up
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...
separately as well.

https://codereview.chromium.org/1882103002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/1882103002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:931: if shard_timeout:
I guess you could eliminate the shard_timeout now as well? Or are there more
users that don't yet have it moved into the GYP/GN files?

[mikecase (-- gone --), 2016-04-12 17:38:18]

lgtm!

[agrieve, 2016-04-12 18:08:07]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-04-12 18:08:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882103002/40001

[agrieve, 2016-04-12 18:09:00]

https://codereview.chromium.org/1882103002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/1882103002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:931: if shard_timeout:
On 2016/04/12 16:46:24, kjellander (chromium) wrote:
> I guess you could eliminate the shard_timeout now as well? Or are there more
> users that don't yet have it moved into the GYP/GN files?

I think just webrtc has this. Already have a separate CL to remove it in the
works :)

[commit-bot: I haz the power, 2016-04-12 18:12:54]

Description was changed from

==========
Switch Android gtests to use generated wrapper scripts

BUG=599919
==========

to

==========
Switch Android gtests to use generated wrapper scripts

BUG=599919

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299863
==========

[commit-bot: I haz the power, 2016-04-12 18:12:55]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299863

[Tima Vaisburd, 2016-04-13 00:48:24]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1879283002/ by timav@chromium.org.

The reason for reverting is: Possible breaks Android GN bot
https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/33766

See http://crbug.com/602750.