Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1882243003: Code completion improvement: in NamedExpressions (m(someNamedParam: ^)), use type information to so… (Closed)

Created:
4 years, 8 months ago by jwren
Modified:
4 years, 8 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Code completion improvement: in NamedExpressions (m(someNamedParam: ^)), use type information to sort variables higher in relevance. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/01aaf8629e6ed483c054a319c8ab6615b4f30bfa

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments from DanR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -11 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 1 chunk +10 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 1 5 chunks +19 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart View 3 chunks +39 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jwren
4 years, 8 months ago (2016-04-13 19:42:34 UTC) #2
danrubel
LGTM https://codereview.chromium.org/1882243003/diff/1/pkg/analysis_server/lib/src/services/completion/dart/optype.dart File pkg/analysis_server/lib/src/services/completion/dart/optype.dart (right): https://codereview.chromium.org/1882243003/diff/1/pkg/analysis_server/lib/src/services/completion/dart/optype.dart#newcode197 pkg/analysis_server/lib/src/services/completion/dart/optype.dart:197: staticType.isDynamic || Would you move this change to ...
4 years, 8 months ago (2016-04-13 21:10:22 UTC) #3
jwren
https://codereview.chromium.org/1882243003/diff/1/pkg/analysis_server/lib/src/services/completion/dart/optype.dart File pkg/analysis_server/lib/src/services/completion/dart/optype.dart (right): https://codereview.chromium.org/1882243003/diff/1/pkg/analysis_server/lib/src/services/completion/dart/optype.dart#newcode197 pkg/analysis_server/lib/src/services/completion/dart/optype.dart:197: staticType.isDynamic || On 2016/04/13 21:10:22, danrubel wrote: > Would ...
4 years, 8 months ago (2016-04-13 23:11:24 UTC) #4
jwren
4 years, 8 months ago (2016-04-13 23:11:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
01aaf8629e6ed483c054a319c8ab6615b4f30bfa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698