pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart - Issue 1882243003: Code completion improvement: in NamedExpressions (m(someNamedParam: ^)), use type information to so…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

Issue 1882243003: Code completion improvement: in NamedExpressions (m(someNamedParam: ^)), use type information to so… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Comments from DanR Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/optype.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

index b6dab4c79bd6a160fd89bb21aa1d880c2c3df2d3..61a20f22f814443bca0360b4f70f4ff3730a1a7d 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

@@ -413,12 +413,16 @@ class _LocalVisitor extends LocalDeclarationVisitor {

ClassDeclaration classDecl,

FormalParameterList param,

int relevance: DART_RELEVANCE_DEFAULT}) {

- _addLocalSuggestion(id, typeName, elemKind,

- isAbstract: isAbstract,

- isDeprecated: isDeprecated,

- classDecl: classDecl,

- param: param,

- relevance: relevance);

+ int filterResult =

+ optype.returnValueSuggestionsFilter(_staticTypeOfIdentifier(id));

+ if (filterResult != null) {

+ _addLocalSuggestion(id, typeName, elemKind,

+ isAbstract: isAbstract,

+ isDeprecated: isDeprecated,

+ classDecl: classDecl,

+ param: param,

+ relevance: relevance + filterResult);

+ }

}

void _addLocalSuggestion(