Issue 1882233002: Revert "Reland: Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace"

Issue 1882233002: Revert "Reland: Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace" (Closed)

Created:
4 years, 8 months ago by drott

Modified:
4 years, 8 months ago

Reviewers:
drott

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Revert "Reland: Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace" Revert r385631 (commit b2a8582e83ef3022ac1cc65648348dfd168b77cd) causing an increase in memory consumption and regressing performance on multiple platforms, most notably on Android. Reverting to give us time to triage. TBR=drott@chromium.org BUG=601835 Review URL: https://codereview.chromium.org/1880623002 Cr-Commit-Position: refs/heads/master@{#386473} (cherry picked from commit abed5a107d06843c622bf704088618572ec4f83f) Committed: https://chromium.googlesource.com/chromium/src/+/a8c05871f3a521846d96c966eea9886f129d5606

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -35 lines)			Patch
M	third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp	View	11 chunks	+72 lines, -25 lines	0 comments	Download
M	third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

drott

4 years, 8 months ago (2016-04-12 20:46:54 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a8c05871f3a521846d96c966eea9886f129d5606.