Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1880623002: Revert "Reland: Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace" (Closed)

Created:
4 years, 8 months ago by eae
Modified:
4 years, 8 months ago
Reviewers:
drott
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Reland: Move glyph lookup to hb-ot-font and remove glyph cache in HarfBuzzFace" Revert r385631 (commit b2a8582e83ef3022ac1cc65648348dfd168b77cd) causing an increase in memory consumption and regressing performance on multiple platforms, most notably on Android. Reverting to give us time to triage. TBR=drott@chromium.org BUG=601835 Committed: https://crrev.com/abed5a107d06843c622bf704088618572ec4f83f Cr-Commit-Position: refs/heads/master@{#386473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -35 lines) Patch
M third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp View 11 chunks +72 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880623002/1
4 years, 8 months ago (2016-04-11 19:19:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 21:13:16 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abed5a107d06843c622bf704088618572ec4f83f Cr-Commit-Position: refs/heads/master@{#386473}
4 years, 8 months ago (2016-04-11 21:15:08 UTC) #9
drott
We need to backport the revert to M51 branch 2704.
4 years, 8 months ago (2016-04-12 08:16:12 UTC) #10
eae
4 years, 8 months ago (2016-04-12 15:11:09 UTC) #11
Message was sent while issue was closed.
On 2016/04/12 08:16:12, drott wrote:
> We need to backport the revert to M51 branch 2704.

:(


Hopefully it won't be too hard to figure out what caused the regressions.

Powered by Google App Engine
This is Rietveld 408576698