Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: Source/WebKit/chromium/src/ChromeClientImpl.h

Issue 18822004: Extension Error Piping - Blink: WebKit Side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/WebKit/chromium/src/ChromeClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/chromium/src/ChromeClientImpl.h
diff --git a/Source/WebKit/chromium/src/ChromeClientImpl.h b/Source/WebKit/chromium/src/ChromeClientImpl.h
index 7f12b918c8b4d94c9cee37dd877c75e921359308..297597f3d0d4e857317ffd959861d7fa5a9d1cc3 100644
--- a/Source/WebKit/chromium/src/ChromeClientImpl.h
+++ b/Source/WebKit/chromium/src/ChromeClientImpl.h
@@ -98,6 +98,10 @@ public:
WebCore::MessageSource, WebCore::MessageLevel,
const WTF::String& message, unsigned lineNumber,
const WTF::String& sourceID);
+ virtual bool shouldReportDetailedMessage(const WTF::String& source);
+ virtual void reportDetailedMessage(const WTF::String& source,
+ WebCore::MessageLevel, const WTF::String& message,
+ const WTF::String& jsonStackTrace);
Matt Perry 2013/07/10 23:32:07 I think it would be better to extend addMessageToC
Devlin 2013/07/11 01:15:44 Yeah, how much to merge addMessageToConsole() (and
Matt Perry 2013/07/11 02:40:46 Yeah, I'd combine them all. This doesn't feel like
virtual bool canRunBeforeUnloadConfirmPanel();
virtual bool runBeforeUnloadConfirmPanel(
const WTF::String& message, WebCore::Frame*);
« no previous file with comments | « no previous file | Source/WebKit/chromium/src/ChromeClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698