Extension Error Piping - Blink: WebKit Side

Source/WebKit/chromium/src/ChromeClientImpl.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 80 matching lines @@
     virtual bool statusbarVisible();
     virtual void setScrollbarsVisible(bool);
     virtual bool scrollbarsVisible();
     virtual void setMenubarVisible(bool);
     virtual bool menubarVisible();
     virtual void setResizable(bool);
     virtual void addMessageToConsole(
         WebCore::MessageSource, WebCore::MessageLevel,
         const WTF::String& message, unsigned lineNumber,
         const WTF::String& sourceID);
+    virtual bool shouldReportDetailedMessage(const WTF::String& source);
+    virtual void reportDetailedMessage(const WTF::String& source,
+        WebCore::MessageLevel, const WTF::String& message,
+        const WTF::String& jsonStackTrace);

[Matt Perry, 2013/07/10 23:32:07]

I think it would be better to extend addMessageToConsole to include the optional
stack trace.

[Devlin, 2013/07/11 01:15:44]

Yeah, how much to merge addMessageToConsole() (and related) was my biggest
question.  Should we still keep didAddMessageToConsole() and 
reportDetailedMessage() separate (and just merge in addMessageToConsole()),
d'you think?

[Matt Perry, 2013/07/11 02:40:46]

Yeah, I'd combine them all. This doesn't feel like a separate event - it's just
extra data on the addMessageToConsole event.

     virtual bool canRunBeforeUnloadConfirmPanel();
     virtual bool runBeforeUnloadConfirmPanel(
         const WTF::String& message, WebCore::Frame*);
     virtual void closeWindowSoon();
     virtual void runJavaScriptAlert(WebCore::Frame*, const WTF::String&);
     virtual bool runJavaScriptConfirm(WebCore::Frame*, const WTF::String&);
     virtual bool runJavaScriptPrompt(
         WebCore::Frame*, const WTF::String& message,
         const WTF::String& defaultValue, WTF::String& result);
     virtual void setStatusbarText(const WTF::String& message);
@@ skipping 101 matching lines @@
 private:
     explicit NavigatorContentUtilsClientImpl(WebViewImpl*);
 
     WebViewImpl* m_webView;
 };
 #endif
 
 } // namespace WebKit
 
 #endif