Extension Error Piping - Blink: WebKit Side

Source/core/page/ChromeClient.h

Index: Source/core/page/ChromeClient.h
diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h
index 9ae397b19e208104511c862c4e8dc25bd5ec3821..7c1abdfa6c0789b1434b4b44a7313bea2f5c352a 100644
--- a/Source/core/page/ChromeClient.h
+++ b/Source/core/page/ChromeClient.h
@@ -125,12 +125,8 @@ public:
 
     virtual void setResizable(bool) = 0;
 
-    virtual void addMessageToConsole(MessageSource, MessageLevel, const String& message, unsigned lineNumber, const String& sourceID) = 0;
-    // FIXME: Remove this MessageType variant once all the clients are updated.
-    virtual void addMessageToConsole(MessageSource source, MessageType, MessageLevel level, const String& message, unsigned lineNumber, const String& sourceID)
-    {
-        addMessageToConsole(source, level, message, lineNumber, sourceID);
-    }
+    virtual bool shouldReportDetailedMessageForSource(const String&) = 0;

[pfeldman, 2013/08/15 18:36:23]

Parameter name would not hurt.

[Devlin, 2013/08/15 18:44:06]

Done.

+    virtual void addMessageToConsole(MessageSource, MessageLevel, const String& message, unsigned lineNumber, const String& sourceID, const String& stackTrace) = 0;
 
     virtual bool canRunBeforeUnloadConfirmPanel() = 0;
     virtual bool runBeforeUnloadConfirmPanel(const String& message, Frame*) = 0;