Extension Error Piping - Blink: WebKit Side

Source/core/page/ChromeClient.h

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 107 matching lines @@
     virtual bool statusbarVisible() = 0;
 
     virtual void setScrollbarsVisible(bool) = 0;
     virtual bool scrollbarsVisible() = 0;
 
     virtual void setMenubarVisible(bool) = 0;
     virtual bool menubarVisible() = 0;
 
     virtual void setResizable(bool) = 0;
 
-    virtual void addMessageToConsole(MessageSource, MessageLevel, const String& message, unsigned lineNumber, const String& sourceID) = 0;
-    // FIXME: Remove this MessageType variant once all the clients are updated.
-    virtual void addMessageToConsole(MessageSource source, MessageType, MessageLevel level, const String& message, unsigned lineNumber, const String& sourceID)
-    {
-        addMessageToConsole(source, level, message, lineNumber, sourceID);
-    }
+    virtual bool shouldReportDetailedMessageForSource(const String&) = 0;

[pfeldman, 2013/08/15 18:36:23]

Parameter name would not hurt.

[Devlin, 2013/08/15 18:44:06]

Done.

+    virtual void addMessageToConsole(MessageSource, MessageLevel, const String& message, unsigned lineNumber, const String& sourceID, const String& stackTrace) = 0;
 
     virtual bool canRunBeforeUnloadConfirmPanel() = 0;
     virtual bool runBeforeUnloadConfirmPanel(const String& message, Frame*) = 0;
 
     virtual void closeWindowSoon() = 0;
 
     virtual void runJavaScriptAlert(Frame*, const String&) = 0;
     virtual bool runJavaScriptConfirm(Frame*, const String&) = 0;
     virtual bool runJavaScriptPrompt(Frame*, const String& message, const String& defaultValue, String& result) = 0;
     virtual void setStatusbarText(const String&) = 0;
@@ skipping 136 matching lines @@
 
     // Notifies the client a popup was closed.
     virtual void popupClosed(PopupContainer* popupContainer) = 0;
 
 protected:
     virtual ~ChromeClient() { }
 };
 
 }
 #endif // ChromeClient_h