Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: Source/core/loader/EmptyClients.h

Issue 18822004: Extension Error Piping - Blink: WebKit Side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Consolidate [did]AddMessageToConsole() and reportDetailedMessage() Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/EmptyClients.h
diff --git a/Source/core/loader/EmptyClients.h b/Source/core/loader/EmptyClients.h
index 2f104663296ca93fbcca28f8196fbf5ed2c43e8f..f3bf93bc3cc5f05afc7c07d67dc4bd497b7fd51a 100644
--- a/Source/core/loader/EmptyClients.h
+++ b/Source/core/loader/EmptyClients.h
@@ -104,7 +104,8 @@ public:
virtual void setResizable(bool) OVERRIDE { }
- virtual void addMessageToConsole(MessageSource, MessageLevel, const String&, unsigned, const String&) OVERRIDE { }
+ virtual bool shouldReportDetailedMessage(const String&) OVERRIDE { return false; }
+ virtual void addMessageToConsole(MessageSource, MessageLevel, const String&, unsigned, const String&, const String&) OVERRIDE { }
virtual bool canRunBeforeUnloadConfirmPanel() OVERRIDE { return false; }
virtual bool runBeforeUnloadConfirmPanel(const String&, Frame*) OVERRIDE { return true; }
@@ -161,11 +162,11 @@ public:
virtual void scheduleCompositingLayerFlush() OVERRIDE { }
virtual void needTouchEvents(bool) OVERRIDE { }
-
+
virtual void numWheelEventHandlersChanged(unsigned) OVERRIDE { }
-
+
virtual bool shouldRubberBandInDirection(WebCore::ScrollDirection) const OVERRIDE { return false; }
-
+
virtual bool isEmptyChromeClient() const OVERRIDE { return true; }
virtual void didAssociateFormControls(const Vector<RefPtr<Element> >&) OVERRIDE { }

Powered by Google App Engine
This is Rietveld 408576698