Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: public/web/WebViewClient.h

Issue 18822004: Extension Error Piping - Blink: WebKit Side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Consolidate [did]AddMessageToConsole() and reportDetailedMessage() Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/page/PageConsole.cpp ('K') | « Source/core/page/PageConsole.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebViewClient.h
diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h
index d26c424f7350ae6d9d597d003866803ab3ed6c22..b4739e92e6836e792618acae1b6a0debbb64c231 100644
--- a/public/web/WebViewClient.h
+++ b/public/web/WebViewClient.h
@@ -127,9 +127,15 @@ public:
// Misc ----------------------------------------------------------------
- // A new message was added to the console.
+ // Whether or not we should report a detailed message from the given source.
+ virtual bool shouldReportDetailedMessage(const WebString& source) { return false; }
+
+ // A new message was added to the console. If a detailed message should be
+ // reported, a stringified JSON stack trace is included. Otherwise, |stackTrace|
+ // is empty.
virtual void didAddMessageToConsole(
- const WebConsoleMessage&, const WebString& sourceName, unsigned sourceLine) { }
+ const WebConsoleMessage&, const WebString& sourceName,
+ unsigned sourceLine, const WebString& stackTrace) { }
// Called when script in the page calls window.print(). If frame is
// non-null, then it selects a particular frame, including its
« Source/core/page/PageConsole.cpp ('K') | « Source/core/page/PageConsole.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698