Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: public/web/WebViewClient.h

Issue 18822004: Extension Error Piping - Blink: WebKit Side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Consolidate [did]AddMessageToConsole() and reportDetailedMessage() Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 const WebPopupMenuInfo&, WebExternalPopupMenuClient*) { return 0; } 120 const WebPopupMenuInfo&, WebExternalPopupMenuClient*) { return 0; }
121 121
122 // Create a session storage namespace object associated with this WebView. 122 // Create a session storage namespace object associated with this WebView.
123 virtual WebStorageNamespace* createSessionStorageNamespace() { return create SessionStorageNamespace(0); } 123 virtual WebStorageNamespace* createSessionStorageNamespace() { return create SessionStorageNamespace(0); }
124 // FIXME: Remove the argument-taking version once its override is removed fr om Chromium; the argument is unused. 124 // FIXME: Remove the argument-taking version once its override is removed fr om Chromium; the argument is unused.
125 virtual WebStorageNamespace* createSessionStorageNamespace(unsigned quota) { return 0; } 125 virtual WebStorageNamespace* createSessionStorageNamespace(unsigned quota) { return 0; }
126 126
127 127
128 // Misc ---------------------------------------------------------------- 128 // Misc ----------------------------------------------------------------
129 129
130 // A new message was added to the console. 130 // Whether or not we should report a detailed message from the given source.
131 virtual bool shouldReportDetailedMessage(const WebString& source) { return f alse; }
132
133 // A new message was added to the console. If a detailed message should be
134 // reported, a stringified JSON stack trace is included. Otherwise, |stackTr ace|
135 // is empty.
131 virtual void didAddMessageToConsole( 136 virtual void didAddMessageToConsole(
132 const WebConsoleMessage&, const WebString& sourceName, unsigned sourceLi ne) { } 137 const WebConsoleMessage&, const WebString& sourceName,
138 unsigned sourceLine, const WebString& stackTrace) { }
133 139
134 // Called when script in the page calls window.print(). If frame is 140 // Called when script in the page calls window.print(). If frame is
135 // non-null, then it selects a particular frame, including its 141 // non-null, then it selects a particular frame, including its
136 // children, to print. Otherwise, the main frame and its children 142 // children, to print. Otherwise, the main frame and its children
137 // should be printed. 143 // should be printed.
138 virtual void printPage(WebFrame*) { } 144 virtual void printPage(WebFrame*) { }
139 145
140 // Called to retrieve the provider of desktop notifications. 146 // Called to retrieve the provider of desktop notifications.
141 virtual WebNotificationPresenter* notificationPresenter() { return 0; } 147 virtual WebNotificationPresenter* notificationPresenter() { return 0; }
142 148
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 // Informs the browser that the draggable regions have been updated. 399 // Informs the browser that the draggable regions have been updated.
394 virtual void draggableRegionsChanged() { } 400 virtual void draggableRegionsChanged() { }
395 401
396 protected: 402 protected:
397 ~WebViewClient() { } 403 ~WebViewClient() { }
398 }; 404 };
399 405
400 } // namespace WebKit 406 } // namespace WebKit
401 407
402 #endif 408 #endif
OLDNEW
« Source/core/page/PageConsole.cpp ('K') | « Source/core/page/PageConsole.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698