Make CJS_PublicMethods::StrTrim() take a CFX_ByteString

Make CJS_PublicMethods::StrTrim() take a CFX_ByteString

Similar to https://codereview.chromium.org/1876203002 but in a
different file. The result is still not as efficient as possible
owing to the conversions back and forth to C types.

Convert these methods to ordinary functions in anon namespace
while we're at it.

Committed: https://pdfium.googlesource.com/pdfium/+/745611b68cdfcbfb50d792694ed2dc7be9f4f936

[Tom Sepez, 2016-04-12 19:18:05]

Description was changed from

==========
Make CJS_PublicMethods::StrTrim() take a CFX_ByteString

Similar to https://codereview.chromium.org/1876203002 but in a
different file. The result is still not as efficient as possible
owing to the conversions back and forth to C types.
==========

to

==========
Make CJS_PublicMethods::StrTrim() take a CFX_ByteString

Similar to https://codereview.chromium.org/1876203002 but in a
different file. The result is still not as efficient as possible
owing to the conversions back and forth to C types.

Convert these methods to ordinary functions in anon namespace
while we're at it.
==========

[Tom Sepez, 2016-04-12 19:18:05]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-12 19:19:21]

Lei, deja vu.

[Tom Sepez, 2016-04-12 19:25:33]

https://codereview.chromium.org/1882173002/diff/1/fpdfsdk/javascript/PublicMe...
File fpdfsdk/javascript/PublicMethods.cpp (right):

https://codereview.chromium.org/1882173002/diff/1/fpdfsdk/javascript/PublicMe...
fpdfsdk/javascript/PublicMethods.cpp:917: CFX_WideString wstrValue =
StrTrim(w_strValue);
note: trimming right is not strictly necessary but harmless

[Lei Zhang, 2016-04-12 22:07:43]

lgtm

[Tom Sepez, 2016-04-12 23:46:12]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-04-12 23:46:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882173002/1

[commit-bot: I haz the power, 2016-04-12 23:46:39]

Description was changed from

==========
Make CJS_PublicMethods::StrTrim() take a CFX_ByteString

Similar to https://codereview.chromium.org/1876203002 but in a
different file. The result is still not as efficient as possible
owing to the conversions back and forth to C types.

Convert these methods to ordinary functions in anon namespace
while we're at it.
==========

to

==========
Make CJS_PublicMethods::StrTrim() take a CFX_ByteString

Similar to https://codereview.chromium.org/1876203002 but in a
different file. The result is still not as efficient as possible
owing to the conversions back and forth to C types.

Convert these methods to ordinary functions in anon namespace
while we're at it.

Committed:
https://pdfium.googlesource.com/pdfium/+/745611b68cdfcbfb50d792694ed2dc7be9f4...
==========

[commit-bot: I haz the power, 2016-04-12 23:46:40]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/745611b68cdfcbfb50d792694ed2dc7be9f4...