Pass CFX_ByteStrings rather than raw ptrs to JS_GlobalData.

Pass CFX_ByteStrings rather than raw ptrs to JS_GlobalData.

Helps to avoid re-allocating strings when the caller already
has one allocated.

Committed: https://pdfium.googlesource.com/pdfium/+/24a48881c5407651a58cfd6547ac9b6a9823a63e

[Tom Sepez, 2016-04-11 17:51:05]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-11 17:51:06]

Lei, for review.

https://codereview.chromium.org/1876203002/diff/1/fpdfsdk/javascript/JS_Globa...
File fpdfsdk/javascript/JS_GlobalData.cpp (right):

https://codereview.chromium.org/1876203002/diff/1/fpdfsdk/javascript/JS_Globa...
fpdfsdk/javascript/JS_GlobalData.cpp:98: sPropName->TrimLeft();
Note: these are now no-touch if possible, so TrimPropName is likely no-touch,
too.

https://codereview.chromium.org/1876203002/diff/1/fpdfsdk/javascript/JS_Globa...
File fpdfsdk/javascript/JS_GlobalData.h (right):

https://codereview.chromium.org/1876203002/diff/1/fpdfsdk/javascript/JS_Globa...
fpdfsdk/javascript/JS_GlobalData.h:67: void
SetGlobalVariableNumber(CFX_ByteString propname, double dData);
Note: not const, since the first thing the code would do if const would be to
make a non-const version for trimming.

[Lei Zhang, 2016-04-11 19:27:48]

https://codereview.chromium.org/1876203002/diff/1/fpdfsdk/javascript/JS_Globa...
File fpdfsdk/javascript/JS_GlobalData.h (right):

https://codereview.chromium.org/1876203002/diff/1/fpdfsdk/javascript/JS_Globa...
fpdfsdk/javascript/JS_GlobalData.h:67: void
SetGlobalVariableNumber(CFX_ByteString propname, double dData);
On 2016/04/11 17:51:06, Tom Sepez wrote:
> Note: not const, since the first thing the code would do if const would be to
> make a non-const version for trimming.

Doesn't the style guide frown upon passing by value?

[Tom Sepez, 2016-04-11 20:29:54]

https://codereview.chromium.org/1876203002/diff/1/fpdfsdk/javascript/JS_Globa...
File fpdfsdk/javascript/JS_GlobalData.h (right):

https://codereview.chromium.org/1876203002/diff/1/fpdfsdk/javascript/JS_Globa...
fpdfsdk/javascript/JS_GlobalData.h:67: void
SetGlobalVariableNumber(CFX_ByteString propname, double dData);
On 2016/04/11 19:27:48, Lei Zhang wrote:
> On 2016/04/11 17:51:06, Tom Sepez wrote:
> > Note: not const, since the first thing the code would do if const would be
to
> > make a non-const version for trimming.
> 
> Doesn't the style guide frown upon passing by value?
Not sure.  Fair enough though.  Will do.

[Lei Zhang, 2016-04-11 21:41:50]

lgtm

[Tom Sepez, 2016-04-11 21:48:34]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-04-11 21:48:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1876203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1876203002/20001

[commit-bot: I haz the power, 2016-04-11 22:18:44]

Description was changed from

==========
Pass CFX_ByteStrings rather than raw ptrs to JS_GlobalData.

Helps to avoid re-allocating strings when the caller already
has one allocated.
==========

to

==========
Pass CFX_ByteStrings rather than raw ptrs to JS_GlobalData.

Helps to avoid re-allocating strings when the caller already
has one allocated.

Committed:
https://pdfium.googlesource.com/pdfium/+/24a48881c5407651a58cfd6547ac9b6a9823...
==========

[commit-bot: I haz the power, 2016-04-11 22:18:45]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/24a48881c5407651a58cfd6547ac9b6a9823...