Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1882123002: Revert of [iOS] Defaults to use system libjpeg on iOS. (Closed)

Created:
4 years, 8 months ago by sdefresne
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@net
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [iOS] Defaults to use system libjpeg on iOS. (patchset #1 id:1 of https://codereview.chromium.org/1806503002/ ) Reason for revert: Chrome on iOS does not link against libjpeg (neither libjpeg_turbo nor libjpeg) and build using libjpeg_turbo when using gyp. There is no path between //:gn_all and //third_party:jpeg, thus no need to select one version or the other on iOS. Revert the change as it causes link error for WebRTC. $ gn path out/simulator //:gn_all //third_party:jpeg No non-data paths found between these two targets. Original issue's description: > [iOS] Defaults to use system libjpeg on iOS. > > It is currently not possible to build libjpeg_turbo on iOS (and may > not be a good idea in term of application size) so default to using > the version of libjpeg shipped with the system. > > Move the "libs" assignment from the "jpeg" to "system_libjpeg_config" > config. > > BUG=459705 > > Committed: https://crrev.com/689dc0e45d16789f3ce3241d3033601af395c313 > Cr-Commit-Position: refs/heads/master@{#381432} TBR=brettw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=459705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sdefresne
Created Revert of [iOS] Defaults to use system libjpeg on iOS.
4 years, 8 months ago (2016-04-12 17:37:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882123002/1
4 years, 8 months ago (2016-04-12 17:37:29 UTC) #2
sdefresne
4 years, 8 months ago (2016-04-12 18:08:21 UTC) #4
Message was sent while issue was closed.
On 2016/04/12 at 17:37:29, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1882123002/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1882123002/1

Closing as the build can easily be fixed, see
https://codereview.chromium.org/1886443002.

Powered by Google App Engine
This is Rietveld 408576698