Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1886443002: Revert "[iOS] Defaults to use system libjpeg on iOS." (Closed)

Created:
4 years, 8 months ago by sdefresne
Modified:
4 years, 8 months ago
CC:
chromium-reviews, kjellander_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[iOS] Defaults to use system libjpeg on iOS." Fix the configuration of libjpeg_turbo to build on iOS by using the same settings as Mac. This is not used by Chrome on iOS AFAIK, but appears to be used by WebRTC. BUG=602682 Committed: https://crrev.com/cb3f4114b1b74302570e17e09b59b097d6ee406b Cr-Commit-Position: refs/heads/master@{#386941}

Patch Set 1 #

Patch Set 2 : Put back "libs = [ ... ]" in system_libjpeg_config config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/secondary/third_party/libjpeg_turbo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
sdefresne
Please take a look. This fixes the compilation: $ gn gen --args='target_os="ios"' out/Default $ ninja ...
4 years, 8 months ago (2016-04-12 17:45:04 UTC) #2
kjellander_chromium
Thanks a lot for helping out with this! I can confirm that from WebRTC's perspective, ...
4 years, 8 months ago (2016-04-12 19:20:38 UTC) #4
brettw
lgtm
4 years, 8 months ago (2016-04-12 21:57:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886443002/20001
4 years, 8 months ago (2016-04-13 08:21:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 09:05:46 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 09:07:31 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb3f4114b1b74302570e17e09b59b097d6ee406b
Cr-Commit-Position: refs/heads/master@{#386941}

Powered by Google App Engine
This is Rietveld 408576698