Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1881993002: [heap] Fix GC tracing order in FinalizeIncrementalMarking. (Closed)

Created:
4 years, 8 months ago by ulan
Modified:
4 years, 8 months ago
Reviewers:
Michael Lippautz
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix GC tracing order in FinalizeIncrementalMarking. This ensures that GC tracer scope is nested in a trace event. BUG= Committed: https://crrev.com/177e04aacb2b6b157b1cf2a4e4bf904a7c209c3d Cr-Commit-Position: refs/heads/master@{#35413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
ptal
4 years, 8 months ago (2016-04-12 11:03:09 UTC) #2
Michael Lippautz
lgtm
4 years, 8 months ago (2016-04-12 11:20:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881993002/1
4 years, 8 months ago (2016-04-12 11:36:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 11:57:24 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 11:59:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/177e04aacb2b6b157b1cf2a4e4bf904a7c209c3d
Cr-Commit-Position: refs/heads/master@{#35413}

Powered by Google App Engine
This is Rietveld 408576698