Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: src/heap/heap.cc

Issue 1881993002: [heap] Fix GC tracing order in FinalizeIncrementalMarking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/heap.h" 5 #include "src/heap/heap.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/ast/scopeinfo.h" 9 #include "src/ast/scopeinfo.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 806 matching lines...) Expand 10 before | Expand all | Expand 10 after
817 void Heap::ScheduleIdleScavengeIfNeeded(int bytes_allocated) { 817 void Heap::ScheduleIdleScavengeIfNeeded(int bytes_allocated) {
818 scavenge_job_->ScheduleIdleTaskIfNeeded(this, bytes_allocated); 818 scavenge_job_->ScheduleIdleTaskIfNeeded(this, bytes_allocated);
819 } 819 }
820 820
821 821
822 void Heap::FinalizeIncrementalMarking(const char* gc_reason) { 822 void Heap::FinalizeIncrementalMarking(const char* gc_reason) {
823 if (FLAG_trace_incremental_marking) { 823 if (FLAG_trace_incremental_marking) {
824 PrintF("[IncrementalMarking] (%s).\n", gc_reason); 824 PrintF("[IncrementalMarking] (%s).\n", gc_reason);
825 } 825 }
826 826
827 TRACE_GC(tracer(), GCTracer::Scope::MC_INCREMENTAL_FINALIZE);
828 HistogramTimerScope incremental_marking_scope( 827 HistogramTimerScope incremental_marking_scope(
829 isolate()->counters()->gc_incremental_marking_finalize()); 828 isolate()->counters()->gc_incremental_marking_finalize());
830 TRACE_EVENT0("v8", "V8.GCIncrementalMarkingFinalize"); 829 TRACE_EVENT0("v8", "V8.GCIncrementalMarkingFinalize");
830 TRACE_GC(tracer(), GCTracer::Scope::MC_INCREMENTAL_FINALIZE);
831 831
832 { 832 {
833 GCCallbacksScope scope(this); 833 GCCallbacksScope scope(this);
834 if (scope.CheckReenter()) { 834 if (scope.CheckReenter()) {
835 AllowHeapAllocation allow_allocation; 835 AllowHeapAllocation allow_allocation;
836 TRACE_GC(tracer(), GCTracer::Scope::MC_INCREMENTAL_EXTERNAL_PROLOGUE); 836 TRACE_GC(tracer(), GCTracer::Scope::MC_INCREMENTAL_EXTERNAL_PROLOGUE);
837 VMState<EXTERNAL> state(isolate_); 837 VMState<EXTERNAL> state(isolate_);
838 HandleScope handle_scope(isolate_); 838 HandleScope handle_scope(isolate_);
839 CallGCPrologueCallbacks(kGCTypeIncrementalMarking, kNoGCCallbackFlags); 839 CallGCPrologueCallbacks(kGCTypeIncrementalMarking, kNoGCCallbackFlags);
840 } 840 }
(...skipping 5596 matching lines...) Expand 10 before | Expand all | Expand 10 after
6437 } 6437 }
6438 6438
6439 6439
6440 // static 6440 // static
6441 int Heap::GetStaticVisitorIdForMap(Map* map) { 6441 int Heap::GetStaticVisitorIdForMap(Map* map) {
6442 return StaticVisitorBase::GetVisitorId(map); 6442 return StaticVisitorBase::GetVisitorId(map);
6443 } 6443 }
6444 6444
6445 } // namespace internal 6445 } // namespace internal
6446 } // namespace v8 6446 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698