tools/perf/profile_creators/extension_profile_extender_unittest.py - Issue 1881573002: [Perf] Guard against impending output_profile_path option move.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/profile_creators/extension_profile_extender_unittest.py

Issue 1881573002: [Perf] Guard against impending output_profile_path option move. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/profile_creators/extension_profile_extender_unittest.py

diff --git a/tools/perf/profile_creators/extension_profile_extender_unittest.py b/tools/perf/profile_creators/extension_profile_extender_unittest.py

index 604987285bb6dae95eb1a134875ee466f19e44a5..6f5992dedcc7cb4a5ed150bae60f76bbe89f6854 100644

--- a/tools/perf/profile_creators/extension_profile_extender_unittest.py

+++ b/tools/perf/profile_creators/extension_profile_extender_unittest.py

@@ -24,7 +24,12 @@ class ExtensionProfileExtenderUnitTest(page_test_test_case.PageTestTestCase):

files_in_crx_dir = 0

try:

options = options_for_unittests.GetCopy()

- options.output_profile_path = tmp_dir

+ # TODO(eakuefner): Remove this after crrev.com/1874473006 rolls in.

+ try:

+ getattr(options, 'output_profile_path')

+ options.output_profile_path = tmp_dir

+ except AttributeError:

+ options.browser_options.output_profile_path = tmp_dir

extender = extension_profile_extender.ExtensionProfileExtender(options)

extender.Run()

« no previous file with comments | « no previous file | tools/perf/profile_creators/profile_extender.py » ('j') | no next file with comments »