third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html - Issue 1881563003: Implement OffscreenCanvas.getContext('webgl')

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html

Issue 1881563003: Implement OffscreenCanvas.getContext('webgl') (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: offscreenCanvas.getContext('webgl') crashes on worker Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-in-worker.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html

diff --git a/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html b/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html

index be7fad2d54b60a290f746673458268aa8d5a239b..786b1c89c3794f7a128aa61f9b27fb4c2554e7b5 100644

--- a/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html

+++ b/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D.html

@@ -32,7 +32,7 @@ shouldBeTrue("ctx3 == ctx");

// TODO: change the below part of the test when webgl is supported.

// Calling getContext on an unimplemented context type will return null

-var bogusCanvas = new OffscreenCanvas(20, 20);

-var bogusCtx = bogusCanvas.getContext("webgl");

-shouldBeNull("bogusCtx");

+var bCanvas = new OffscreenCanvas(20, 20);

+var ctx4 = bCanvas.getContext("webgl");

Justin Novosad 2016/04/20 20:07:27 Hmmm... test is called "getContext2D" but it cover

xidachen 2016/04/20 20:52:09 Good catch, this will be changed in a future CL on

+shouldBeType("ctx4", "WebGLRenderingContext");

</script>